Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(371)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1862633002: [wasm] Factor trap codes out of wasm-compiler.cc (Closed)

Created:
4 years, 8 months ago by titzer
Modified:
4 years, 8 months ago
Reviewers:
bradnelson, ahaas
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Factor trap codes out of wasm-compiler.cc R=ahaas@chromium.org,bradnelson@chromium.org BUG= Committed: https://crrev.com/dc226e6160a016d01d7f2472f1f062dced92871e Cr-Commit-Position: refs/heads/master@{#35274}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -65 lines) Patch
M src/compiler/wasm-compiler.cc View 28 chunks +45 lines, -65 lines 0 comments Download
M src/wasm/wasm-opcodes.h View 1 2 chunks +36 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
titzer
4 years, 8 months ago (2016-04-05 14:34:31 UTC) #1
bradnelson
lgtm
4 years, 8 months ago (2016-04-05 16:04:32 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1862633002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1862633002/20001
4 years, 8 months ago (2016-04-05 17:06:32 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-05 17:28:50 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-05 17:29:39 UTC) #8
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/dc226e6160a016d01d7f2472f1f062dced92871e
Cr-Commit-Position: refs/heads/master@{#35274}

Powered by Google App Engine
This is Rietveld 408576698