Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1862623003:
cc: Use scroll layer bounds as scrollable area size (Closed)
Descriptioncc: Use scroll layer bounds as scrollable area size
LTI::ScrollableSize suspiciously took the bounds of the first child
of the scrollable layer as the scrollable area size because of some
racing condition in blink.
Now we are not sure if the racing condition still exists. This CL
tries to use the bounds of the scrollable layer itself and see if
it breaks anything.
BUG=233853, 598381
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Committed: https://crrev.com/cae4f1070f808d4c1f8ebce25901d653191be3bc
Cr-Commit-Position: refs/heads/master@{#385464}
Patch Set 1 #
Messages
Total messages: 16 (11 generated)
Description was changed from ========== cc: Use scroll layer bounds as scrollable area size BUG=233853 ========== to ========== cc: Use scroll layer bounds as scrollable area size BUG=233853 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel ==========
Description was changed from ========== cc: Use scroll layer bounds as scrollable area size BUG=233853 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel ========== to ========== cc: Use scroll layer bounds as scrollable area size LTI::ScrollableSize suspiciously took the bounds of the first child of the scrollable layer as the scrollable area size, this was because some racing condition in blink. Now we are not sure if the racing condition still exists. This CL tries to use the bounds of the scrollable layer itself and see if it breaks anything. BUG=233853, 598381 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel ==========
sunxd@chromium.org changed reviewers: + ajuma@chromium.org, bokan@chromium.org, jaydasika@chromium.org, vollick@chromium.org
Description was changed from ========== cc: Use scroll layer bounds as scrollable area size LTI::ScrollableSize suspiciously took the bounds of the first child of the scrollable layer as the scrollable area size, this was because some racing condition in blink. Now we are not sure if the racing condition still exists. This CL tries to use the bounds of the scrollable layer itself and see if it breaks anything. BUG=233853, 598381 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel ========== to ========== cc: Use scroll layer bounds as scrollable area size LTI::ScrollableSize suspiciously took the bounds of the first child of the scrollable layer as the scrollable area size, this was because some racing condition in blink. Now we are not sure if the racing condition still exists. This CL tries to use the bounds of the scrollable layer itself and see if it breaks anything. BUG=233853, 598381 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel ==========
Description was changed from ========== cc: Use scroll layer bounds as scrollable area size LTI::ScrollableSize suspiciously took the bounds of the first child of the scrollable layer as the scrollable area size, this was because some racing condition in blink. Now we are not sure if the racing condition still exists. This CL tries to use the bounds of the scrollable layer itself and see if it breaks anything. BUG=233853, 598381 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel ========== to ========== cc: Use scroll layer bounds as scrollable area size LTI::ScrollableSize suspiciously took the bounds of the first child of the scrollable layer as the scrollable area size, this was because some racing condition in blink. Now we are not sure if the racing condition still exists. This CL tries to use the bounds of the scrollable layer itself and see if it breaks anything. BUG=233853, 598381 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel ==========
Description was changed from ========== cc: Use scroll layer bounds as scrollable area size LTI::ScrollableSize suspiciously took the bounds of the first child of the scrollable layer as the scrollable area size, this was because some racing condition in blink. Now we are not sure if the racing condition still exists. This CL tries to use the bounds of the scrollable layer itself and see if it breaks anything. BUG=233853, 598381 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel ========== to ========== cc: Use scroll layer bounds as scrollable area size LTI::ScrollableSize suspiciously took the bounds of the first child of the scrollable layer as the scrollable area size, this was because some racing condition in blink. Now we are not sure if the racing condition still exists. This CL tries to use the bounds of the scrollable layer itself and see if it breaks anything. BUG=233853, 598381 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel ==========
Description was changed from ========== cc: Use scroll layer bounds as scrollable area size LTI::ScrollableSize suspiciously took the bounds of the first child of the scrollable layer as the scrollable area size, this was because some racing condition in blink. Now we are not sure if the racing condition still exists. This CL tries to use the bounds of the scrollable layer itself and see if it breaks anything. BUG=233853, 598381 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel ========== to ========== cc: Use scroll layer bounds as scrollable area size LTI::ScrollableSize suspiciously took the bounds of the first child of the scrollable layer as the scrollable area size, this was because some racing condition in blink. Now we are not sure if the racing condition still exists. This CL tries to use the bounds of the scrollable layer itself and see if it breaks anything. BUG=233853, 598381 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel ==========
Description was changed from ========== cc: Use scroll layer bounds as scrollable area size LTI::ScrollableSize suspiciously took the bounds of the first child of the scrollable layer as the scrollable area size, this was because some racing condition in blink. Now we are not sure if the racing condition still exists. This CL tries to use the bounds of the scrollable layer itself and see if it breaks anything. BUG=233853, 598381 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel ========== to ========== cc: Use scroll layer bounds as scrollable area size LTI::ScrollableSize suspiciously took the bounds of the first child of the scrollable layer as the scrollable area size because of some racing condition in blink. Now we are not sure if the racing condition still exists. This CL tries to use the bounds of the scrollable layer itself and see if it breaks anything. BUG=233853, 598381 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel ==========
lgtm
The CQ bit was checked by sunxd@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1862623003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1862623003/1
Message was sent while issue was closed.
Description was changed from ========== cc: Use scroll layer bounds as scrollable area size LTI::ScrollableSize suspiciously took the bounds of the first child of the scrollable layer as the scrollable area size because of some racing condition in blink. Now we are not sure if the racing condition still exists. This CL tries to use the bounds of the scrollable layer itself and see if it breaks anything. BUG=233853, 598381 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel ========== to ========== cc: Use scroll layer bounds as scrollable area size LTI::ScrollableSize suspiciously took the bounds of the first child of the scrollable layer as the scrollable area size because of some racing condition in blink. Now we are not sure if the racing condition still exists. This CL tries to use the bounds of the scrollable layer itself and see if it breaks anything. BUG=233853, 598381 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== cc: Use scroll layer bounds as scrollable area size LTI::ScrollableSize suspiciously took the bounds of the first child of the scrollable layer as the scrollable area size because of some racing condition in blink. Now we are not sure if the racing condition still exists. This CL tries to use the bounds of the scrollable layer itself and see if it breaks anything. BUG=233853, 598381 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel ========== to ========== cc: Use scroll layer bounds as scrollable area size LTI::ScrollableSize suspiciously took the bounds of the first child of the scrollable layer as the scrollable area size because of some racing condition in blink. Now we are not sure if the racing condition still exists. This CL tries to use the bounds of the scrollable layer itself and see if it breaks anything. BUG=233853, 598381 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/cae4f1070f808d4c1f8ebce25901d653191be3bc Cr-Commit-Position: refs/heads/master@{#385464} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/cae4f1070f808d4c1f8ebce25901d653191be3bc Cr-Commit-Position: refs/heads/master@{#385464} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
