Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Issue 1862623002: docs: start migrating android build instructions to markdown (Closed)

Created:
4 years, 8 months ago by tfarina
Modified:
4 years, 8 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

docs: start migrating android build instructions to markdown This is the first part of what is found in https://www.chromium.org/developers/how-tos/android-build-instructions To convert the html page to markdown, pandoc tool was used. After having it converted, it was manual changed while inspecting in http://dillinger.io. The command lines ran were: $ wget https://www.chromium.org/developers/how-tos/android-build-instructions $ pandoc -s -r html android-build-instructions -o android_build_instructions.md BUG=None TEST=open android_build_instructions.md in a Markdown visualizer and make sure it looks good. R=dpranke@chromium.org,newt@chromium.org Committed: https://crrev.com/2c773222cfdf6f9251a12bca55a8ff15b699a42a Cr-Commit-Position: refs/heads/master@{#385238}

Patch Set 1 #

Total comments: 2

Patch Set 2 : rm trailing \ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -0 lines) Patch
A docs/android_build_instructions.md View 1 1 chunk +77 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
tfarina
I think it will be easier to review and catch mistakes earlier than doing everything ...
4 years, 8 months ago (2016-04-05 13:30:47 UTC) #1
newt (away)
This lgtm, but what's the plan for converting the rest of the page? We don't ...
4 years, 8 months ago (2016-04-05 16:54:19 UTC) #2
Dirk Pranke
lgtm
4 years, 8 months ago (2016-04-05 17:08:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1862623002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1862623002/20001
4 years, 8 months ago (2016-04-05 17:19:55 UTC) #6
tfarina
I will get to it during this and the next few days. If for some ...
4 years, 8 months ago (2016-04-05 17:21:27 UTC) #7
newt (away)
On 2016/04/05 17:21:27, tfarina wrote: > I will get to it during this and the ...
4 years, 8 months ago (2016-04-05 17:29:02 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-05 18:43:45 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-04-05 18:45:19 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2c773222cfdf6f9251a12bca55a8ff15b699a42a
Cr-Commit-Position: refs/heads/master@{#385238}

Powered by Google App Engine
This is Rietveld 408576698