Prerender need to be on the Oilpan heap.

Prerender need to be on the Oilpan heap.

The object implementing the PrerenderClient is LinkLoader, which is
an object that's Oilpan heap allocated. Consequently, it cannot be
kept Prerender as a bare pointer, but needs to be traced and accounted
for during garbage collections.

The simplest way to handle that is to move Prerender to the Oilpan
heap.

R=haraken,jochen
BUG=

Committed: https://crrev.com/31f5a364105b491bcded86af3e40b3552534335b
Cr-Commit-Position: refs/heads/master@{#386007}

[sof, 2016-04-06 21:22:37]

sigbjornf@opera.com changed reviewers:
+ oilpan-reviews@chromium.org

[sof, 2016-04-06 21:22:38]

please take a look.

[haraken, 2016-04-07 00:08:11]

haraken@chromium.org changed reviewers:
+ haraken@chromium.org

[haraken, 2016-04-07 00:08:12]

https://codereview.chromium.org/1862593005/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/loader/PrerenderHandle.cpp (right):

https://codereview.chromium.org/1862593005/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/loader/PrerenderHandle.cpp:70: detach();

Now you cannot touch m_prerender in the destructor?

[sof, 2016-04-07 05:12:13]

https://codereview.chromium.org/1862593005/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/loader/PrerenderHandle.cpp (right):

https://codereview.chromium.org/1862593005/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/loader/PrerenderHandle.cpp:70: detach();
On 2016/04/07 00:08:12, haraken wrote:
> 
> Now you cannot touch m_prerender in the destructor?

Like for other eagerly finalized objects, you can touch objects in other lazy,
sub heaps (or arenas, to use the current term/naming.)

[haraken, 2016-04-07 05:20:43]

On 2016/04/07 05:12:13, sof wrote:
>
https://codereview.chromium.org/1862593005/diff/1/third_party/WebKit/Source/c...
> File third_party/WebKit/Source/core/loader/PrerenderHandle.cpp (right):
> 
>
https://codereview.chromium.org/1862593005/diff/1/third_party/WebKit/Source/c...
> third_party/WebKit/Source/core/loader/PrerenderHandle.cpp:70: detach();
> On 2016/04/07 00:08:12, haraken wrote:
> > 
> > Now you cannot touch m_prerender in the destructor?
> 
> Like for other eagerly finalized objects, you can touch objects in other lazy,
> sub heaps (or arenas, to use the current term/naming.)

LGTM

[sof, 2016-04-07 05:44:35]

The CQ bit was checked by sigbjornf@opera.com

[commit-bot: I haz the power, 2016-04-07 05:44:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1862593005/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1862593005/1

[commit-bot: I haz the power, 2016-04-07 05:54:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-07 05:54:13]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[sof, 2016-04-07 06:22:40]

sigbjornf@opera.com changed reviewers:
+ jochen@chromium.org

[sof, 2016-04-07 06:22:41]

jochen@: could you take a look at the tweak to WebPrerender in public/ ? thanks

[jochen (gone - plz use gerrit), 2016-04-08 02:47:11]

lgtm

[sof, 2016-04-08 05:44:58]

Description was changed from

==========
Prerender need to be on the Oilpan heap.

The object implementing the PrerenderClient is LinkLoader, which is
an object that's Oilpan heap allocated. Consequently, it cannot be
kept Prerender as a bare pointer, but needs to be traced and accounted
for during garbage collections.

The simplest way to handle that is to move Prerender to the Oilpan
heap.

R=
BUG=
==========

to

==========
Prerender need to be on the Oilpan heap.

The object implementing the PrerenderClient is LinkLoader, which is
an object that's Oilpan heap allocated. Consequently, it cannot be
kept Prerender as a bare pointer, but needs to be traced and accounted
for during garbage collections.

The simplest way to handle that is to move Prerender to the Oilpan
heap.

R=haraken,jochen
BUG=
==========

[sof, 2016-04-08 05:45:07]

The CQ bit was checked by sigbjornf@opera.com

[commit-bot: I haz the power, 2016-04-08 05:45:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1862593005/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1862593005/1

[commit-bot: I haz the power, 2016-04-08 06:30:25]

Description was changed from

==========
Prerender need to be on the Oilpan heap.

The object implementing the PrerenderClient is LinkLoader, which is
an object that's Oilpan heap allocated. Consequently, it cannot be
kept Prerender as a bare pointer, but needs to be traced and accounted
for during garbage collections.

The simplest way to handle that is to move Prerender to the Oilpan
heap.

R=haraken,jochen
BUG=
==========

to

==========
Prerender need to be on the Oilpan heap.

The object implementing the PrerenderClient is LinkLoader, which is
an object that's Oilpan heap allocated. Consequently, it cannot be
kept Prerender as a bare pointer, but needs to be traced and accounted
for during garbage collections.

The simplest way to handle that is to move Prerender to the Oilpan
heap.

R=haraken,jochen
BUG=
==========

[commit-bot: I haz the power, 2016-04-08 06:30:26]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-04-08 06:31:31]

Description was changed from

==========
Prerender need to be on the Oilpan heap.

The object implementing the PrerenderClient is LinkLoader, which is
an object that's Oilpan heap allocated. Consequently, it cannot be
kept Prerender as a bare pointer, but needs to be traced and accounted
for during garbage collections.

The simplest way to handle that is to move Prerender to the Oilpan
heap.

R=haraken,jochen
BUG=
==========

to

==========
Prerender need to be on the Oilpan heap.

The object implementing the PrerenderClient is LinkLoader, which is
an object that's Oilpan heap allocated. Consequently, it cannot be
kept Prerender as a bare pointer, but needs to be traced and accounted
for during garbage collections.

The simplest way to handle that is to move Prerender to the Oilpan
heap.

R=haraken,jochen
BUG=

Committed: https://crrev.com/31f5a364105b491bcded86af3e40b3552534335b
Cr-Commit-Position: refs/heads/master@{#386007}
==========

[commit-bot: I haz the power, 2016-04-08 06:31:33]

Patchset 1 (id:??) landed as
https://crrev.com/31f5a364105b491bcded86af3e40b3552534335b
Cr-Commit-Position: refs/heads/master@{#386007}