media: Fix gn deps on media/ targets.

media: Fix gn deps on media/ targets.

gn check out/GN //media/ passes.

BUG=599578
Committed: https://crrev.com/0200f0dbad660eea2415b7c468b454dcdbabeaf9
Cr-Commit-Position: refs/heads/master@{#387212}

[jrummell, 2016-04-05 01:18:04]

jrummell@chromium.org changed reviewers:
+ dalecurtis@chromium.org

[jrummell, 2016-04-05 01:18:04]

PTAL.

[DaleCurtis, 2016-04-05 01:22:41]

Why do we want nogncheck?

[jrummell, 2016-04-05 17:20:56]

> Why do we want nogncheck?
"ppapi/cpp/logging.h" is only included if we are building the pepper CDM
adapters. It's not included if we're building the mojo CDM adapter. Since gn
check looks at all #includes (regardless of conditional flags), it's complaining
that the mojo adapter doesn't have a dependency to ppapi/cpp.

[xhwang, 2016-04-12 21:16:02]

xhwang@chromium.org changed reviewers:
+ xhwang@chromium.org

[xhwang, 2016-04-12 21:16:03]

Based on the offline discussion. The current approach is good. I just have one
comment left.

https://chromiumcodereview.appspot.com/1862543002/diff/1/media/BUILD.gn
File media/BUILD.gn (right):

https://chromiumcodereview.appspot.com/1862543002/diff/1/media/BUILD.gn#newco...
media/BUILD.gn:77: "cdm/api/content_decryption_module.h",
Can we have this one in a separate source_set?

[jrummell, 2016-04-13 22:59:13]

Updated. Since I had to add a deps= in template("ppapi_cdm_adapter"), I also
moved the ppapi deps to it as well.

https://codereview.chromium.org/1862543002/diff/1/media/BUILD.gn
File media/BUILD.gn (right):

https://codereview.chromium.org/1862543002/diff/1/media/BUILD.gn#newcode77
media/BUILD.gn:77: "cdm/api/content_decryption_module.h",
On 2016/04/12 21:16:03, xhwang wrote:
> Can we have this one in a separate source_set?

Done.

[xhwang, 2016-04-13 23:05:41]

lgtm with one comment.

https://codereview.chromium.org/1862543002/diff/20001/media/BUILD.gn
File media/BUILD.gn (right):

https://codereview.chromium.org/1862543002/diff/20001/media/BUILD.gn#newcode89
media/BUILD.gn:89: "cdm/cdm_wrapper.h",
We should conditionally include these in "media", e.g. when mojo_cdm is enabled
and when pepper based cdm is enabled. We can do that in a separate CL though.

[jrummell, 2016-04-13 23:16:33]

Thanks for the reviews.

https://codereview.chromium.org/1862543002/diff/20001/media/BUILD.gn
File media/BUILD.gn (right):

https://codereview.chromium.org/1862543002/diff/20001/media/BUILD.gn#newcode89
media/BUILD.gn:89: "cdm/cdm_wrapper.h",
On 2016/04/13 23:05:41, xhwang wrote:
> We should conditionally include these in "media", e.g. when mojo_cdm is
enabled
> and when pepper based cdm is enabled. We can do that in a separate CL though.

Acknowledged.

[jrummell, 2016-04-13 23:16:38]

The CQ bit was checked by jrummell@chromium.org

[commit-bot: I haz the power, 2016-04-13 23:17:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1862543002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1862543002/20001

[commit-bot: I haz the power, 2016-04-14 02:27:05]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-04-14 02:28:34]

Description was changed from

==========
media: Fix gn deps on media/ targets.

gn check out/GN //media/ passes.

BUG=599578
==========

to

==========
media: Fix gn deps on media/ targets.

gn check out/GN //media/ passes.

BUG=599578

Committed: https://crrev.com/0200f0dbad660eea2415b7c468b454dcdbabeaf9
Cr-Commit-Position: refs/heads/master@{#387212}
==========

[commit-bot: I haz the power, 2016-04-14 02:28:35]

Patchset 2 (id:??) landed as
https://crrev.com/0200f0dbad660eea2415b7c468b454dcdbabeaf9
Cr-Commit-Position: refs/heads/master@{#387212}