Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(396)

Issue 1862533002: [DevTools] Speculative chrome os tests fix (Closed)

Created:
4 years, 8 months ago by kozy
Modified:
4 years, 8 months ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, kinuko+watch, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Speculative chrome os tests fix After analysis every return point of V8RuntimAgentImpl::evaluate only one suspicious return was found in InjectedScript::wrapValue. If function.call returns empty value without exception then we return empty MaybeLocal and return from wrapEvaluateResult without setting errorString. BUG=599947 R=dgozman@chromium.org Committed: https://crrev.com/be7bba69f100b52764f24e5545356a09f72f540f Cr-Commit-Position: refs/heads/master@{#385113}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/platform/v8_inspector/InjectedScript.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
kozy
Dmitry, please take a look.
4 years, 8 months ago (2016-04-05 01:11:50 UTC) #1
dgozman
lgtm
4 years, 8 months ago (2016-04-05 01:27:43 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1862533002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1862533002/1
4 years, 8 months ago (2016-04-05 04:38:10 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-05 06:03:16 UTC) #5
commit-bot: I haz the power
4 years, 8 months ago (2016-04-05 06:04:29 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/be7bba69f100b52764f24e5545356a09f72f540f
Cr-Commit-Position: refs/heads/master@{#385113}

Powered by Google App Engine
This is Rietveld 408576698