Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1862503002:
Fix regression in 1c9b02233631b0ba9b096d79bf5b8d71a370dbb0. (Closed)
|
Created:
4 years, 8 months ago by M-A Ruel Modified:
4 years, 8 months ago Reviewers:
Łukasz Anforowicz CC:
chromium-reviews Base URL:
https://chromium.googlesource.com/a/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionFix regression in 1c9b02233631b0ba9b096d79bf5b8d71a370dbb0.
R=lukasza@chromium.org
TBR=lukasza@chromium.org
BUG=587694
NOTRY=true
Committed: https://chromium.googlesource.com/chromium/src/+/031aebddd2c595f9bcbf9c11457b5b23ced055fa
Patch Set 1 #
Messages
Total messages: 15 (7 generated)
Description was changed from ========== Fix regression in 1c9b02233631b0ba9b096d79bf5b8d71a370dbb0. TBR=lukasza@chromium.org BUG= BUG=587694 ========== to ========== Fix regression in 1c9b02233631b0ba9b096d79bf5b8d71a370dbb0. TBR=lukasza@chromium.org BUG=587694 NOTRY=true ==========
LGTM
The CQ bit was checked by maruel@chromium.org
The CQ bit was unchecked by maruel@chromium.org
The CQ bit was checked by maruel@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1862503002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1862503002/1
The CQ bit was unchecked by maruel@chromium.org
Message was sent while issue was closed.
Description was changed from ========== Fix regression in 1c9b02233631b0ba9b096d79bf5b8d71a370dbb0. TBR=lukasza@chromium.org BUG=587694 NOTRY=true ========== to ========== Fix regression in 1c9b02233631b0ba9b096d79bf5b8d71a370dbb0. R=lukasza@chromium.org TBR=lukasza@chromium.org BUG=587694 NOTRY=true Committed: https://crrev.com/031aebddd2c595f9bcbf9c11457b5b23ced055fa Cr-Commit-Position: refs/heads/master@{#385057} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/031aebddd2c595f9bcbf9c11457b5b23ced055fa Cr-Commit-Position: refs/heads/master@{#385057}
Message was sent while issue was closed.
Description was changed from ========== Fix regression in 1c9b02233631b0ba9b096d79bf5b8d71a370dbb0. R=lukasza@chromium.org TBR=lukasza@chromium.org BUG=587694 NOTRY=true Committed: https://crrev.com/031aebddd2c595f9bcbf9c11457b5b23ced055fa Cr-Commit-Position: refs/heads/master@{#385057} ========== to ========== Fix regression in 1c9b02233631b0ba9b096d79bf5b8d71a370dbb0. R=lukasza@chromium.org TBR=lukasza@chromium.org BUG=587694 NOTRY=true Committed: https://chromium.googlesource.com/chromium/src/+/031aebddd2c595f9bcbf9c11457b... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 031aebddd2c595f9bcbf9c11457b5b23ced055fa (tree was closed).
Message was sent while issue was closed.
On 2016/04/05 at 00:19:41, maruel wrote: > Committed patchset #1 (id:1) manually as 031aebddd2c595f9bcbf9c11457b5b23ced055fa (tree was closed). Why wasn't this error caught by the bots in the first place?
Message was sent while issue was closed.
On 2016/04/05 03:52:51, mithro wrote: > On 2016/04/05 at 00:19:41, maruel wrote: > > Committed patchset #1 (id:1) manually as > 031aebddd2c595f9bcbf9c11457b5b23ced055fa (tree was closed). > > Why wasn't this error caught by the bots in the first place? Because the problematic line is only executed in 5 out of 24 hours of a day: https://chromium.googlesource.com/chromium/src/+/031aebddd2c595f9bcbf9c11457b... now = datetime.datetime.utcnow() if now.hour < 5: ... # runtime error happens here
Message was sent while issue was closed.
On 2016/04/05 04:20:43, Łukasz Anforowicz wrote: > On 2016/04/05 03:52:51, mithro wrote: > > On 2016/04/05 at 00:19:41, maruel wrote: > > > Committed patchset #1 (id:1) manually as > > 031aebddd2c595f9bcbf9c11457b5b23ced055fa (tree was closed). > > > > Why wasn't this error caught by the bots in the first place? > > Because the problematic line is only executed in 5 out of 24 hours of a day: > > https://chromium.googlesource.com/chromium/src/+/031aebddd2c595f9bcbf9c11457b... > > now = datetime.datetime.utcnow() > if now.hour < 5: > ... > # runtime error happens here I just hit this also. Very funny (broke at 5:00 pm PST) - I guess I won't try building again until 10:00 pm PST. Well, I guess I'll sync 'cause this is probably fixed. |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
