Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 1862413007: Remove dead histograms and actions (Closed)

Created:
4 years, 8 months ago by piman
Modified:
4 years, 8 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove dead histograms and actions This is post-NPAPI removal. BUG=493212 Committed: https://crrev.com/ddc2da85019dabed108d729190cd6aaeb95fe211 Cr-Commit-Position: refs/heads/master@{#386580}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : tag as obsolete instead of remove #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -0 lines) Patch
M tools/metrics/actions/actions.xml View 1 2 3 chunks +5 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 7 chunks +21 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (7 generated)
piman
4 years, 8 months ago (2016-04-07 22:51:12 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1862413007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1862413007/1
4 years, 8 months ago (2016-04-08 03:45:50 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-08 04:58:21 UTC) #6
piman
Kindly ping?
4 years, 8 months ago (2016-04-11 18:32:57 UTC) #7
Alexei Svitkine (slow)
Thanks for the ping. Instead of removing them, please mark them as <obsolete> as this ...
4 years, 8 months ago (2016-04-11 20:30:48 UTC) #8
piman
On 2016/04/11 20:30:48, Alexei Svitkine wrote: > Thanks for the ping. > > Instead of ...
4 years, 8 months ago (2016-04-11 20:58:10 UTC) #9
Alexei Svitkine (slow)
lgtm
4 years, 8 months ago (2016-04-11 20:58:34 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1862413007/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1862413007/40001
4 years, 8 months ago (2016-04-11 21:07:49 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/209261)
4 years, 8 months ago (2016-04-12 00:27:31 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1862413007/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1862413007/40001
4 years, 8 months ago (2016-04-12 01:46:54 UTC) #16
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 8 months ago (2016-04-12 04:17:19 UTC) #17
commit-bot: I haz the power
4 years, 8 months ago (2016-04-12 04:18:43 UTC) #19
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/ddc2da85019dabed108d729190cd6aaeb95fe211
Cr-Commit-Position: refs/heads/master@{#386580}

Powered by Google App Engine
This is Rietveld 408576698