Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 1862333002: ipc: Rename TakeFileHandleForProcess->TakePlatformFileForTransit. (Closed)

Created:
4 years, 8 months ago by erikchen
Modified:
4 years, 8 months ago
CC:
chromium-reviews, tzik, Lei Zhang, grt+watch_chromium.org, jam, nhiroki, tommycli, darin-cc_chromium.org, kinuko+fileapi
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ipc: Rename TakeFileHandleForProcess->TakePlatformFileForTransit. This CL has no intended behavior change. This CL also removes the now unnecessary parameter |process|. BUG=493414 Committed: https://crrev.com/41e608362245c754380232a2effdce714987f530 Cr-Commit-Position: refs/heads/master@{#385781}

Patch Set 1 #

Patch Set 2 : Compile error. #

Patch Set 3 : Compile errors. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -85 lines) Patch
M chrome/browser/media_galleries/fileapi/safe_audio_video_checker.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M chrome/browser/media_galleries/fileapi/safe_iapps_library_parser.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/media_galleries/fileapi/safe_picasa_album_table_reader.cc View 1 chunk +10 lines, -17 lines 0 comments Download
M chrome/browser/printing/pwg_raster_converter.cc View 2 chunks +6 lines, -9 lines 0 comments Download
M chrome/browser/safe_browsing/sandboxed_dmg_analyzer_mac.cc View 1 chunk +1 line, -10 lines 0 comments Download
M chrome/browser/safe_browsing/sandboxed_zip_analyzer.cc View 1 chunk +1 line, -9 lines 0 comments Download
M chrome/service/service_utility_process_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/nacl/browser/nacl_file_host.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M components/nacl/browser/nacl_host_message_filter.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M components/nacl/browser/nacl_process_host.cc View 2 chunks +4 lines, -6 lines 0 comments Download
M components/nacl/renderer/manifest_service_channel.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/database_message_filter.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/pepper/pepper_flash_file_message_filter.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 2 4 chunks +4 lines, -7 lines 0 comments Download
M ipc/ipc_platform_file.h View 1 1 chunk +3 lines, -4 lines 0 comments Download
M ipc/ipc_platform_file.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 24 (11 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1862333002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1862333002/1
4 years, 8 months ago (2016-04-07 01:16:56 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1862333002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1862333002/20001
4 years, 8 months ago (2016-04-07 01:20:59 UTC) #5
erikchen
thestig: Please review chrome/ mseaborn: Please review components/nacl/ avi: Please review content/ tsepez: Please review ...
4 years, 8 months ago (2016-04-07 01:21:48 UTC) #7
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: cast_shell_android on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_android/builds/46629)
4 years, 8 months ago (2016-04-07 01:34:45 UTC) #9
Avi (use Gerrit)
lgtm
4 years, 8 months ago (2016-04-07 01:51:43 UTC) #10
Lei Zhang
chrome/ lgtm, but the bots are red...
4 years, 8 months ago (2016-04-07 02:02:04 UTC) #11
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1862333002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1862333002/40001
4 years, 8 months ago (2016-04-07 02:14:39 UTC) #13
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-07 03:35:08 UTC) #15
Tom Sepez
ipc lgtm
4 years, 8 months ago (2016-04-07 15:33:58 UTC) #16
Mark Seaborn
On 2016/04/07 01:21:48, erikchen wrote: > mseaborn: Please review components/nacl/ LGTM
4 years, 8 months ago (2016-04-07 16:16:56 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1862333002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1862333002/40001
4 years, 8 months ago (2016-04-07 16:28:39 UTC) #20
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 8 months ago (2016-04-07 16:35:53 UTC) #22
commit-bot: I haz the power
4 years, 8 months ago (2016-04-07 16:37:28 UTC) #24
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/41e608362245c754380232a2effdce714987f530
Cr-Commit-Position: refs/heads/master@{#385781}

Powered by Google App Engine
This is Rietveld 408576698