Issue 18623: Add back convolver_unittest.cc and image_operations_unittest.cc....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 18623: Add back convolver_unittest.cc and image_operations_unittest.cc.... (Closed)

Created:
11 years, 11 months ago by M-A Ruel

Modified:
9 years, 7 months ago

Reviewers:
brettw

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Add back convolver_unittest.cc and image_operations_unittest.cc. Fix a TODO in platform_canvas_unittest.cc. Make vector_canvas_unittest.cc slightly less dependent on base/. Remove Windows 2000 checks. BUG=5113 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=8458

Patch Set 1 #

Patch Set 2 : Had forgot vector_canvas_unittest.cc! and scons #

Created: 11 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+87 lines, -112 lines)			Patch
M	skia/ext/image_operations_unittest.cc	View	1	2 chunks	+2 lines, -3 lines	0 comments	Download
M	skia/ext/platform_canvas_unittest.cc	View	1	11 chunks	+15 lines, -19 lines	0 comments	Download
M	skia/ext/vector_canvas_unittest.cc	View		15 chunks	+58 lines, -89 lines	0 comments	Download
M	webkit/tools/test_shell/SConscript	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	webkit/tools/test_shell/image_decoder_unittest.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/tools/test_shell/test_shell_tests.vcproj	View	1	2 chunks	+8 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

M-A Ruel

This doesn't remove all the dependencies but that's a start...

11 years, 11 months ago (2009-01-22 02:22:57 UTC) #1

LGTM, thanks for doing this.

Expand Messages | Collapse Messages