Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 1862293003: Fetch: Fix 'body' processing in RequestInit. (Closed)

Created:
4 years, 8 months ago by Mike West
Modified:
4 years, 8 months ago
Reviewers:
philipj_slow, horo
CC:
blink-reviews, chromium-reviews, haraken
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fetch: Fix 'body' processing in RequestInit. https://codereview.chromium.org/1844053003 broke 'RequestInit's ability to process a body on a request with 'credentials' set because it was bypassing 'body' processing if any 'credentials' property was set. It _should_ have been bypassing 'body' processing if and only if the 'credentials' attribute contained a 'PasswordCredential' object. This patch fixes the broken comparison. BUG=599597 Committed: https://crrev.com/93a08a4b973b9cca6f7f3d182d9a13102755da2b Cr-Commit-Position: refs/heads/master@{#385716}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -1 line) Patch
M third_party/WebKit/LayoutTests/http/tests/credentialmanager/passwordcredential-fetch.html View 1 chunk +10 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/fetch/script-tests/request.js View 1 chunk +12 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/fetch/RequestInit.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (6 generated)
Mike West
Hello folks in my timezone who probably know enough about Fetch to stamp this tiny ...
4 years, 8 months ago (2016-04-07 10:39:54 UTC) #2
Mike West
On 2016/04/07 at 10:39:54, Mike West wrote: > Hello folks in my timezone who probably ...
4 years, 8 months ago (2016-04-07 10:41:15 UTC) #4
horo
lgtm
4 years, 8 months ago (2016-04-07 10:55:59 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1862293003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1862293003/1
4 years, 8 months ago (2016-04-07 10:57:10 UTC) #7
Mike West
Thanks!
4 years, 8 months ago (2016-04-07 10:57:13 UTC) #9
philipj_slow
Another LGTM if needed.
4 years, 8 months ago (2016-04-07 11:18:03 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-07 11:57:21 UTC) #12
commit-bot: I haz the power
4 years, 8 months ago (2016-04-07 11:58:57 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/93a08a4b973b9cca6f7f3d182d9a13102755da2b
Cr-Commit-Position: refs/heads/master@{#385716}

Powered by Google App Engine
This is Rietveld 408576698