Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Issue 1862243006: [Mac] Prevent extension icon animation when window not visible. (Closed)

Created:
4 years, 8 months ago by shrike
Modified:
4 years, 8 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Mac] Prevent extension icon animation when window not visible. When you drag a tab out of its window the extension icons animate into position even though it should appear that the tab and its controls are being removed as-is from their window. This makes the tab dragging effect look klunky and unpolished. R=avi@chromium.org BUG=601264 Committed: https://crrev.com/5a583e6115fec107f2d4a1cffa69d5f572d89a57 Cr-Commit-Position: refs/heads/master@{#386096}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M chrome/browser/ui/cocoa/extensions/browser_actions_controller.mm View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
shrike
PTAL
4 years, 8 months ago (2016-04-07 23:24:12 UTC) #1
Avi (use Gerrit)
lgtm
4 years, 8 months ago (2016-04-07 23:25:55 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1862243006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1862243006/1
4 years, 8 months ago (2016-04-07 23:26:51 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/207799)
4 years, 8 months ago (2016-04-08 00:58:57 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1862243006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1862243006/1
4 years, 8 months ago (2016-04-08 15:38:05 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-08 16:33:32 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-04-08 16:34:35 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5a583e6115fec107f2d4a1cffa69d5f572d89a57
Cr-Commit-Position: refs/heads/master@{#386096}

Powered by Google App Engine
This is Rietveld 408576698