Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(995)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java

Issue 1862243004: Remove the flag for search text fake omnibox from function that is used elsewhere to localised point (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@always-show-snippets
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java
index ad759e4ac12a18071009c7b2b90dfb5709a12845..cba655e1692b4e378615d292688354343f91c16f 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java
@@ -52,6 +52,7 @@ import org.chromium.chrome.browser.profiles.MostVisitedSites.MostVisitedURLsObse
import org.chromium.chrome.browser.profiles.MostVisitedSites.ThumbnailCallback;
import org.chromium.chrome.browser.util.ViewUtils;
import org.chromium.chrome.browser.widget.RoundedIconGenerator;
+import org.chromium.ui.base.DeviceFormFactor;
import jp.tomorrowkey.android.gifplayer.BaseGifImage;
@@ -257,11 +258,10 @@ public class NewTabPageView extends FrameLayout
*
* @param manager NewTabPageManager used to perform various actions when the user interacts
* with the page.
- * @param isSingleUrlBarMode Whether the NTP is in single URL bar mode.
* @param searchProviderHasLogo Whether the search provider has a logo.
* @param useCardsUi Whether to use the new cards based UI or the old one.
*/
- public void initialize(NewTabPageManager manager, boolean isSingleUrlBarMode,
+ public void initialize(NewTabPageManager manager,
boolean searchProviderHasLogo, boolean useCardsUi) {
mManager = manager;
ViewStub stub = (ViewStub) findViewById(R.id.new_tab_page_layout_stub);
@@ -297,7 +297,8 @@ public class NewTabPageView extends FrameLayout
mSearchBoxTextView = (TextView) mSearchBoxView.findViewById(R.id.search_box_text);
String hintText = getResources().getString(R.string.search_or_type_url);
- if (isSingleUrlBarMode) {
+
+ if (!DeviceFormFactor.isTablet(getContext()) || manager.isFakeOmniboxTextEnabledTablet()) {
mSearchBoxTextView.setHint(hintText);
} else {
mSearchBoxTextView.setContentDescription(hintText);
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698