Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 1862243002: Remove IFWL_Grid and other grid classes. (Closed)

Created:
4 years, 8 months ago by dsinclair
Modified:
4 years, 8 months ago
Reviewers:
Tom Sepez, Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Remove IFWL_Grid and other grid classes. The IFWL_Grid class wasn't an interface, it was a concrete class. Even as a concrete class it was never instantiated. The various other CFWL_Grid* class were also not instantiated. BUG=pdfium:468 Committed: https://pdfium.googlesource.com/pdfium/+/72851be38d09908efb0d3eca248ee9d3fc655773

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1694 lines) Patch
M BUILD.gn View 2 chunks +0 lines, -3 lines 0 comments Download
M xfa.gyp View 2 chunks +0 lines, -3 lines 0 comments Download
D xfa/fwl/core/fwl_gridimp.h View 1 chunk +0 lines, -197 lines 0 comments Download
D xfa/fwl/core/fwl_gridimp.cpp View 1 chunk +0 lines, -1382 lines 0 comments Download
M xfa/fwl/core/fwl_noteimp.cpp View 3 chunks +2 lines, -7 lines 0 comments Download
M xfa/fwl/core/fwl_panelimp.cpp View 2 chunks +1 line, -9 lines 0 comments Download
D xfa/fwl/core/ifwl_grid.h View 1 chunk +0 lines, -93 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
dsinclair
PTAL.
4 years, 8 months ago (2016-04-06 20:07:58 UTC) #2
Tom Sepez
lgtm
4 years, 8 months ago (2016-04-06 20:37:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1862243002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1862243002/1
4 years, 8 months ago (2016-04-06 20:39:49 UTC) #5
commit-bot: I haz the power
4 years, 8 months ago (2016-04-06 20:40:07 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/72851be38d09908efb0d3eca248ee9d3fc65...

Powered by Google App Engine
This is Rietveld 408576698