Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issue 1862223005: Add setIndexedDBClientCreateFunction() explanatory comment. (Closed)

Created:
4 years, 8 months ago by sof
Modified:
4 years, 8 months ago
Reviewers:
haraken
CC:
chromium-reviews, blink-reviews, jsbell+idb_chromium.org, cmumford
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add setIndexedDBClientCreateFunction() explanatory comment. Follow up changes in r385772 and r385733 with a comment to try to explain why update atomicity matters here. R= BUG=598551, 599011 NOTRY=true Committed: https://crrev.com/4fa5dd8ee1e6f6c8719935152f3b48f82626d595 Cr-Commit-Position: refs/heads/master@{#386000}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M third_party/WebKit/Source/modules/indexeddb/IndexedDBClient.cpp View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
sof
To try to avoid unnecessary head scratching for whoever looks at this code next..
4 years, 8 months ago (2016-04-08 05:39:36 UTC) #2
haraken
LGTM
4 years, 8 months ago (2016-04-08 05:45:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1862223005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1862223005/1
4 years, 8 months ago (2016-04-08 05:50:32 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-08 05:55:34 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-08 05:56:43 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4fa5dd8ee1e6f6c8719935152f3b48f82626d595
Cr-Commit-Position: refs/heads/master@{#386000}

Powered by Google App Engine
This is Rietveld 408576698