Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4856)

Unified Diff: chrome/browser/profiles/profile.h

Issue 1862203005: Remove ContentBrowserClient::CreateRequestContext & CreateRequestContextForStoragePartition. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/profiles/profile.h
diff --git a/chrome/browser/profiles/profile.h b/chrome/browser/profiles/profile.h
index 1339c4e2e4686d84e2752f2ec8fe1c8f3bd5b21d..8ca5c06409bc4fbedd5998264eb79d22969c9749 100644
--- a/chrome/browser/profiles/profile.h
+++ b/chrome/browser/profiles/profile.h
@@ -223,29 +223,6 @@ class Profile : public content::BrowserContext {
// the user started chrome.
virtual base::Time GetStartTime() const = 0;
- // Creates the main net::URLRequestContextGetter that will be returned by
- // GetRequestContext(). Should only be called once per ContentBrowserClient
- // object. This function is exposed because of the circular dependency where
- // GetStoragePartition() is used to retrieve the request context, but creation
- // still has to happen in the Profile so the StoragePartition calls
- // ContextBrowserClient to call this function.
- // TODO(ajwong): Remove once http://crbug.com/159193 is resolved.
- virtual net::URLRequestContextGetter* CreateRequestContext(
- content::ProtocolHandlerMap* protocol_handlers,
- content::URLRequestInterceptorScopedVector request_interceptors) = 0;
-
- // Creates the net::URLRequestContextGetter for a StoragePartition. Should
- // only be called once per partition_path per ContentBrowserClient object.
- // This function is exposed because the request context is retrieved from the
- // StoragePartition, but creation still has to happen in the Profile so the
- // StoragePartition calls ContextBrowserClient to call this function.
- // TODO(ajwong): Remove once http://crbug.com/159193 is resolved.
- virtual net::URLRequestContextGetter* CreateRequestContextForStoragePartition(
- const base::FilePath& partition_path,
- bool in_memory,
- content::ProtocolHandlerMap* protocol_handlers,
- content::URLRequestInterceptorScopedVector request_interceptors) = 0;
-
// Returns the last directory that was chosen for uploading or opening a file.
virtual base::FilePath last_selected_directory() = 0;
virtual void set_last_selected_directory(const base::FilePath& path) = 0;

Powered by Google App Engine
This is Rietveld 408576698