Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 1862203004: Set the working directory on relaunch (Closed)

Created:
4 years, 8 months ago by scottmg
Modified:
4 years, 8 months ago
Reviewers:
grt (UTC plus 2)
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Set the working directory on relaunch The working directory seems to be set during DLL load. Since we don't set one here, I think the end result is that that's inherited to the relaunched child. R=grt@chromium.org BUG=601143 Committed: https://crrev.com/20920cb19ec396276f3e772072e659fdb8f39ae0 Cr-Commit-Position: refs/heads/master@{#385778}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M chrome/browser/first_run/upgrade_util_win.cc View 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
scottmg
4 years, 8 months ago (2016-04-06 22:38:31 UTC) #1
grt (UTC plus 2)
Subtle! Thanks for tracking this down. LGTM.
4 years, 8 months ago (2016-04-07 13:28:44 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1862203004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1862203004/1
4 years, 8 months ago (2016-04-07 16:18:43 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-07 16:24:08 UTC) #5
commit-bot: I haz the power
4 years, 8 months ago (2016-04-07 16:25:05 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/20920cb19ec396276f3e772072e659fdb8f39ae0
Cr-Commit-Position: refs/heads/master@{#385778}

Powered by Google App Engine
This is Rietveld 408576698