Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(658)

Issue 1862203003: [MediaSession, Test] Move MediaSession test data to all-platforms directory (Closed)

Created:
4 years, 8 months ago by Zhiqiang Zhang (Slow)
Modified:
4 years, 8 months ago
CC:
chromium-reviews, darin-cc_chromium.org, feature-media-reviews_chromium.org, jam, mcasas+watch_chromium.org, posciak+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[MediaSession, Test] Move MediaSession test data to all-platforms directory Since MediaSession is no longer Android-only, this CL moves the test data out from the android/ test directory. BUG=587471 Committed: https://crrev.com/01e0dea8ecdfb80206af68a20bc795f059f25c23 Cr-Commit-Position: refs/heads/master@{#386056}

Patch Set 1 #

Patch Set 2 : fix isolate file #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Total comments: 4

Patch Set 6 : sort isolate files #

Patch Set 7 : fixing... #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -39 lines) Patch
M chrome/android/javatests/src/org/chromium/chrome/browser/media/ui/PauseOnHeadsetUnplugTest.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_public_test_apk.isolate View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M content/browser/media/session/media_session_visibility_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/content_shell_test_apk.isolate View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/MediaSessionTest.java View 1 chunk +1 line, -1 line 0 comments Download
D content/test/data/android/media/audio-1second.ogg View Binary file 0 comments Download
D content/test/data/android/media/audio-4seconds.ogg View Binary file 0 comments Download
D content/test/data/android/media/audio-6seconds.ogg View Binary file 0 comments Download
D content/test/data/android/media/media-session.html View 1 chunk +0 lines, -36 lines 0 comments Download
D content/test/data/android/media/video-1second.webm View Binary file 0 comments Download
D content/test/data/android/media/video-4seconds.webm View Binary file 0 comments Download
D content/test/data/android/media/video-6seconds.webm View Binary file 0 comments Download
D content/test/data/android/media/video-6seconds-silent.webm View Binary file 0 comments Download
A + content/test/data/media/session/audio-1second.ogg View Binary file 0 comments Download
A + content/test/data/media/session/audio-4seconds.ogg View Binary file 0 comments Download
A + content/test/data/media/session/audio-6seconds.ogg View Binary file 0 comments Download
A + content/test/data/media/session/media-session.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + content/test/data/media/session/video-1second.webm View Binary file 0 comments Download
A + content/test/data/media/session/video-4seconds.webm View Binary file 0 comments Download
A + content/test/data/media/session/video-6seconds.webm View Binary file 0 comments Download
A + content/test/data/media/session/video-6seconds-silent.webm View Binary file 0 comments Download

Messages

Total messages: 16 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1862203003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1862203003/80001
4 years, 8 months ago (2016-04-07 14:23:32 UTC) #2
Zhiqiang Zhang (Slow)
maruel@chromium.org: Please review changes in *.isolate mlamouri@chromium.org: Please review changes in all other files
4 years, 8 months ago (2016-04-07 14:40:42 UTC) #5
M-A Ruel
https://codereview.chromium.org/1862203003/diff/80001/chrome/chrome_public_test_apk.isolate File chrome/chrome_public_test_apk.isolate (right): https://codereview.chromium.org/1862203003/diff/80001/chrome/chrome_public_test_apk.isolate#newcode27 chrome/chrome_public_test_apk.isolate:27: '<(DEPTH)/content/test/data/media/session/', sort https://codereview.chromium.org/1862203003/diff/80001/content/content_shell_test_apk.isolate File content/content_shell_test_apk.isolate (right): https://codereview.chromium.org/1862203003/diff/80001/content/content_shell_test_apk.isolate#newcode9 content/content_shell_test_apk.isolate:9: '<(DEPTH)/content/test/data/media/session/', ...
4 years, 8 months ago (2016-04-07 14:48:49 UTC) #6
Zhiqiang Zhang (Slow)
PTAL, sorted *.isolate files https://codereview.chromium.org/1862203003/diff/80001/chrome/chrome_public_test_apk.isolate File chrome/chrome_public_test_apk.isolate (right): https://codereview.chromium.org/1862203003/diff/80001/chrome/chrome_public_test_apk.isolate#newcode27 chrome/chrome_public_test_apk.isolate:27: '<(DEPTH)/content/test/data/media/session/', On 2016/04/07 14:48:49, M-A ...
4 years, 8 months ago (2016-04-07 14:59:15 UTC) #7
M-A Ruel
lgtm
4 years, 8 months ago (2016-04-07 15:04:41 UTC) #8
mlamouri (slow - plz ping)
lgtm \o/
4 years, 8 months ago (2016-04-08 09:16:07 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1862203003/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1862203003/120001
4 years, 8 months ago (2016-04-08 12:38:11 UTC) #12
commit-bot: I haz the power
Committed patchset #7 (id:120001)
4 years, 8 months ago (2016-04-08 12:44:53 UTC) #14
commit-bot: I haz the power
4 years, 8 months ago (2016-04-08 12:47:00 UTC) #16
Message was sent while issue was closed.
Patchset 7 (id:??) landed as
https://crrev.com/01e0dea8ecdfb80206af68a20bc795f059f25c23
Cr-Commit-Position: refs/heads/master@{#386056}

Powered by Google App Engine
This is Rietveld 408576698