net/http/http_stream_factory_impl_job.cc - Issue 1862193002: Enable QUIC for proxies only when QUIC is enabled

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/http/http_stream_factory_impl_job.cc

Issue 1862193002: Enable QUIC for proxies only when QUIC is enabled (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed sclittle comments Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/http/http_stream_factory_impl_job.cc

diff --git a/net/http/http_stream_factory_impl_job.cc b/net/http/http_stream_factory_impl_job.cc

index 152ec3f3d71fd62294f9d379d4eb677affd24ce8..25c8485424ae412a121128bb7d734239b59dc10c 100644

--- a/net/http/http_stream_factory_impl_job.cc

+++ b/net/http/http_stream_factory_impl_job.cc

@@ -877,7 +877,7 @@ int HttpStreamFactoryImpl::Job::DoResolveProxyComplete(int result) {

ProxyServer::SCHEME_HTTPS | ProxyServer::SCHEME_SOCKS4 |

ProxyServer::SCHEME_SOCKS5;

- if (session_->params().enable_quic_for_proxies)

+ if (session_->params().enable_quic)

supported_proxies |= ProxyServer::SCHEME_QUIC;

proxy_info_.RemoveProxiesWithoutScheme(supported_proxies);

@@ -959,7 +959,7 @@ int HttpStreamFactoryImpl::Job::DoInitConnection() {

if (proxy_info_.is_quic()) {

using_quic_ = true;

- DCHECK(session_->params().enable_quic_for_proxies);

+ DCHECK(session_->params().enable_quic);

}

if (proxy_info_.is_https() || proxy_info_.is_quic()) {