Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1208)

Unified Diff: chrome/browser/extensions/context_menu_matcher.h

Issue 186213003: <webview>: Context menu API implementation CL. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Put ExtensionKey into MenuItem::Id. Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/context_menu_matcher.h
diff --git a/chrome/browser/extensions/context_menu_matcher.h b/chrome/browser/extensions/context_menu_matcher.h
index 51707afee97b74d4de1a93de64b677db26e41f6d..782b8d3fd6db201fb1f20eb8746d37c25e67b1d6 100644
--- a/chrome/browser/extensions/context_menu_matcher.h
+++ b/chrome/browser/extensions/context_menu_matcher.h
@@ -34,7 +34,7 @@ class ContextMenuMatcher {
// This is a helper function to append items for one particular extension.
// The |index| parameter is used for assigning id's, and is incremented for
// each item actually added.
- void AppendExtensionItems(const std::string& extension_id,
+ void AppendExtensionItems(const MenuItem::ExtensionKey& extension_key,
const base::string16& selection_text,
int* index);
@@ -43,7 +43,7 @@ class ContextMenuMatcher {
// This function returns the top level context menu title of an extension
// based on a printable selection text.
base::string16 GetTopLevelContextMenuTitle(
- const std::string& extension_id,
+ const MenuItem::ExtensionKey& extension_key,
const base::string16& selection_text);
bool IsCommandIdChecked(int command_id) const;
@@ -56,7 +56,7 @@ class ContextMenuMatcher {
friend class ::ExtensionContextMenuBrowserTest;
bool GetRelevantExtensionTopLevelItems(
- const std::string& extension_id,
+ const MenuItem::ExtensionKey& extension_key,
const Extension** extension,
bool* can_cross_incognito,
MenuItem::List& items);

Powered by Google App Engine
This is Rietveld 408576698