Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1998)

Unified Diff: chrome/browser/extensions/api/context_menus/context_menus_api.cc

Issue 186213003: <webview>: Context menu API implementation CL. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Put ExtensionKey into MenuItem::Id. Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/context_menus/context_menus_api.cc
diff --git a/chrome/browser/extensions/api/context_menus/context_menus_api.cc b/chrome/browser/extensions/api/context_menus/context_menus_api.cc
index 4c5e6b56836793889b47030d056be76300a18a56..d277663e5230deba98c3805b30e1c3abda8f825f 100644
--- a/chrome/browser/extensions/api/context_menus/context_menus_api.cc
+++ b/chrome/browser/extensions/api/context_menus/context_menus_api.cc
@@ -96,14 +96,15 @@ bool ContextMenusRemoveFunction::RunImpl() {
if (!manager->RemoveContextMenuItem(id))
return false;
- manager->WriteToStorage(GetExtension());
+ manager->WriteToStorage(GetExtension(), id.extension_key);
return true;
}
bool ContextMenusRemoveAllFunction::RunImpl() {
MenuManager* manager = MenuManager::Get(GetProfile());
- manager->RemoveAllContextItems(GetExtension()->id());
- manager->WriteToStorage(GetExtension());
+ manager->RemoveAllContextItems(MenuItem::ExtensionKey(GetExtension()->id()));
+ manager->WriteToStorage(GetExtension(),
+ MenuItem::ExtensionKey(GetExtension()->id()));
return true;
}

Powered by Google App Engine
This is Rietveld 408576698