path_stroke_with_zero_length: turn off drawFat() by default.

path_stroke_with_zero_length: turn off drawFat() by default.

The replay modes cannot readback, and so cannot draw the fat parts, which
means we've had to exempt them from checking that they draw identically.

I don't mind if we leave it alone, but I thought I'd check to see your opinion.

BUG=skia:4095
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1862113004

Committed: https://skia.googlesource.com/skia/+/48156ed412410c9d27b560e8596e3f34d175a277

[mtklein_C, 2016-04-06 20:38:48]

Description was changed from

==========
path_stroke_with_zero_length: turn off drawFat() by default.

The replay modes cannot readback, and so cannot draw the fat parts, which
means we've had to exempt them from checking that they draw identically.

I don't mind if we leave it alone, but I thought I'd check to see your opinion.

BUG=skia:4095
==========

to

==========
path_stroke_with_zero_length: turn off drawFat() by default.

The replay modes cannot readback, and so cannot draw the fat parts, which
means we've had to exempt them from checking that they draw identically.

I don't mind if we leave it alone, but I thought I'd check to see your opinion.

BUG=skia:4095
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[mtklein_C, 2016-04-06 20:39:32]

mtklein@chromium.org changed reviewers:
+ caryclark@google.com

[mtklein_C, 2016-04-06 20:39:35]

The CQ bit was checked by mtklein@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-06 20:39:44]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1862113004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1862113004/1

[caryclark, 2016-04-06 20:45:54]

lgtm

It was helpful when developing this code to see the zoomed up version of the
pixels to make sure that it was correct. 

Hopefully there are no bugs in that area now, so removing that capability is not
so big a deal.

On the other hand, instead of 

if (false ...

I wonder if it would be feasible to have

if (running_under_sample_app ...

So that Gold and dm would never have to see this but, should this bug crop up
again, it would be easy to diagnose when running SampleApp...

[commit-bot: I haz the power, 2016-04-06 20:49:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-06 20:49:36]

Dry run: This issue passed the CQ dry run.

[mtklein_C, 2016-04-06 20:52:44]

> On the other hand, instead of 
> 
> if (false ...
> 
> I wonder if it would be feasible to have
> 
> if (running_under_sample_app ...
> 
> So that Gold and dm would never have to see this but, should this bug crop up
again, it would be easy to diagnose when running SampleApp...

It sure is!  PTAL.

[mtklein_C, 2016-04-06 20:53:11]

The CQ bit was checked by mtklein@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-06 20:53:14]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1862113004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1862113004/20001

[commit-bot: I haz the power, 2016-04-06 20:58:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-06 20:58:28]

Dry run: Try jobs failed on following builders:
  Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot on client.skia (JOB_FAILED,
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...)

[mtklein_C, 2016-04-06 21:00:24]

The CQ bit was checked by mtklein@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-06 21:00:35]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1862113004/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1862113004/40001

[caryclark, 2016-04-06 21:12:03]

lgtm 

cool, I've never seen that before -- very helpful

[commit-bot: I haz the power, 2016-04-06 21:12:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-06 21:12:10]

Dry run: This issue passed the CQ dry run.

[mtklein, 2016-04-06 21:24:08]

The CQ bit was checked by mtklein@google.com

[commit-bot: I haz the power, 2016-04-06 21:24:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1862113004/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1862113004/40001

[commit-bot: I haz the power, 2016-04-06 21:25:38]

Description was changed from

==========
path_stroke_with_zero_length: turn off drawFat() by default.

The replay modes cannot readback, and so cannot draw the fat parts, which
means we've had to exempt them from checking that they draw identically.

I don't mind if we leave it alone, but I thought I'd check to see your opinion.

BUG=skia:4095
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
path_stroke_with_zero_length: turn off drawFat() by default.

The replay modes cannot readback, and so cannot draw the fat parts, which
means we've had to exempt them from checking that they draw identically.

I don't mind if we leave it alone, but I thought I'd check to see your opinion.

BUG=skia:4095
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/48156ed412410c9d27b560e8596e3f34d175a277
==========

[commit-bot: I haz the power, 2016-04-06 21:25:39]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/48156ed412410c9d27b560e8596e3f34d175a277