Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1098)

Unified Diff: base/task_scheduler/scheduler_worker_thread_unittest.cc

Issue 1862113002: TaskScheduler: Don't use a callback to post a task from TaskTracker. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | base/task_scheduler/task_tracker.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/task_scheduler/scheduler_worker_thread_unittest.cc
diff --git a/base/task_scheduler/scheduler_worker_thread_unittest.cc b/base/task_scheduler/scheduler_worker_thread_unittest.cc
index 279638859405eaac6b0569c8f8fabaaf9e1aaece..63e1cf6e6d69543cdff118b3a7708d58f74f1805 100644
--- a/base/task_scheduler/scheduler_worker_thread_unittest.cc
+++ b/base/task_scheduler/scheduler_worker_thread_unittest.cc
@@ -130,12 +130,12 @@ class TaskSchedulerWorkerThreadTest : public testing::Test,
// Create a Sequence that contains one Task.
scoped_refptr<Sequence> sequence(new Sequence);
- task_tracker_.PostTask(
- Bind(IgnoreResult(&Sequence::PushTask), Unretained(sequence.get())),
- WrapUnique(new Task(
- FROM_HERE, Bind(&TaskSchedulerWorkerThreadTest::RunTaskCallback,
- Unretained(this)),
- TaskTraits())));
+ std::unique_ptr<Task> task(new Task(
+ FROM_HERE,
+ Bind(&TaskSchedulerWorkerThreadTest::RunTaskCallback, Unretained(this)),
+ TaskTraits()));
+ EXPECT_TRUE(task_tracker_.WillPostTask(task.get()));
+ sequence->PushTask(std::move(task));
{
// Add the Sequence to the vector of created Sequences.
« no previous file with comments | « no previous file | base/task_scheduler/task_tracker.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698