Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1615)

Issue 18621004: Make ChromeOS build exit nonzero on failure (Closed)

Created:
7 years, 5 months ago by borenet
Modified:
7 years, 5 months ago
Reviewers:
djsollen
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Make ChromeOS build exit nonzero on failure R=djsollen@google.com Committed: https://code.google.com/p/skia/source/detail?r=10018

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -4 lines) Patch
M platform_tools/chromeos/bin/build_skia_in_chroot View 1 chunk +2 lines, -0 lines 0 comments Download
M platform_tools/chromeos/bin/chromeos_make View 1 chunk +5 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
borenet
Obviously, you can't do two builds at once with this, but I don't know if ...
7 years, 5 months ago (2013-07-11 18:07:19 UTC) #1
djsollen
lgtm
7 years, 5 months ago (2013-07-11 18:08:29 UTC) #2
borenet
7 years, 5 months ago (2013-07-11 18:11:58 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r10018 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698