V8: Add s390 bots.

V8: Add s390 bots.

BUG=595733
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299742

[Michael Achenbach, 2016-04-06 14:19:04]

Description was changed from

==========
V8: Add s390 bots.

BUG=
==========

to

==========
V8: Add s390 bots.

BUG=595733
==========

[Michael Achenbach, 2016-04-06 14:19:04]

machenbach@chromium.org changed reviewers:
+ kjellander@chromium.org, sergiyb@chromium.org

[Michael Achenbach, 2016-04-06 14:20:06]

The CQ bit was checked by machenbach@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-06 14:20:09]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1862083002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1862083002/1

[Michael Achenbach, 2016-04-06 14:21:13]

PTAL

https://codereview.chromium.org/1862083002/diff/1/masters/master.client.v8.po...
File masters/master.client.v8.ports/slaves.cfg (right):

https://codereview.chromium.org/1862083002/diff/1/masters/master.client.v8.po...
masters/master.client.v8.ports/slaves.cfg:15: 'hostname': 'slave26-c3',
Removed that slave from client.v8 here:
https://codereview.chromium.org/1858233002/

[Michael Achenbach, 2016-04-06 14:23:09]

CC IBM folks. I could also add a mail notifier for that bot including the CC'ed
emails from IBM. Is that useful?

[john.yan, 2016-04-06 14:33:43]

On 2016/04/06 14:23:09, Michael Achenbach wrote:
> CC IBM folks. I could also add a mail notifier for that bot including the
CC'ed
> emails from IBM. Is that useful?

Yes, that would be very useful! thanks.

[commit-bot: I haz the power, 2016-04-06 14:38:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-06 14:38:20]

Dry run: This issue passed the CQ dry run.

[Michael Achenbach, 2016-04-06 14:54:28]

The CQ bit was checked by machenbach@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-06 14:54:36]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1862083002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1862083002/20001

[commit-bot: I haz the power, 2016-04-06 14:58:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-06 14:58:27]

Dry run: This issue passed the CQ dry run.

[kjellander_chromium, 2016-04-06 15:09:59]

lgtm

https://codereview.chromium.org/1862083002/diff/20001/scripts/slave/recipe_mo...
File scripts/slave/recipe_modules/v8/builders.py (right):

https://codereview.chromium.org/1862083002/diff/20001/scripts/slave/recipe_mo...
scripts/slave/recipe_modules/v8/builders.py:1547: 'TARGET_BITS': 64,
So the x in s390x means 64-bit?

[Michael Achenbach, 2016-04-06 16:03:18]

https://codereview.chromium.org/1862083002/diff/20001/scripts/slave/recipe_mo...
File scripts/slave/recipe_modules/v8/builders.py (right):

https://codereview.chromium.org/1862083002/diff/20001/scripts/slave/recipe_mo...
scripts/slave/recipe_modules/v8/builders.py:1547: 'TARGET_BITS': 64,
On 2016/04/06 15:09:59, kjellander (chromium) wrote:
> So the x in s390x means 64-bit?

s390x has 64 while s390 has 31 bits (yes 1). I don't really know if the bitness
of the target arch plays any role. Guess not. It's just important that the
simulator runs the correct v8 code.

[Sergiy Byelozyorov, 2016-04-06 16:42:07]

lgtm w/ a comment and a question

https://codereview.chromium.org/1862083002/diff/20001/masters/master.client.v...
File masters/master.client.v8.ports/master.cfg (right):

https://codereview.chromium.org/1862083002/diff/20001/masters/master.client.v...
masters/master.client.v8.ports/master.cfg:53: CATEGORY_X87 = '2X87|x87'
Is 1X87->2X97 change intentional? This doesn't seem to be related to S390
changes in the rest of this CL.

https://codereview.chromium.org/1862083002/diff/20001/scripts/slave/recipe_mo...
File scripts/slave/recipe_modules/v8/builders.py (right):

https://codereview.chromium.org/1862083002/diff/20001/scripts/slave/recipe_mo...
scripts/slave/recipe_modules/v8/builders.py:1547: 'TARGET_BITS': 64,
On 2016/04/06 16:03:18, Michael Achenbach wrote:
> s390x has 64 while s390 has 31 bits (yes 1).
Wow! How does this work?

[Michael Achenbach, 2016-04-06 17:36:44]

https://codereview.chromium.org/1862083002/diff/20001/masters/master.client.v...
File masters/master.client.v8.ports/master.cfg (right):

https://codereview.chromium.org/1862083002/diff/20001/masters/master.client.v...
masters/master.client.v8.ports/master.cfg:53: CATEGORY_X87 = '2X87|x87'
On 2016/04/06 16:42:07, Sergiy Byelozyorov wrote:
> Is 1X87->2X97 change intentional? This doesn't seem to be related to S390
> changes in the rest of this CL.

Yes. The 1 and 2 offsets cant be seen. This just moves the buildbot category one
to the right in the UI. It will look like:
S390 | X87

https://codereview.chromium.org/1862083002/diff/20001/scripts/slave/recipe_mo...
File scripts/slave/recipe_modules/v8/builders.py (right):

https://codereview.chromium.org/1862083002/diff/20001/scripts/slave/recipe_mo...
scripts/slave/recipe_modules/v8/builders.py:1547: 'TARGET_BITS': 64,
On 2016/04/06 16:42:07, Sergiy Byelozyorov wrote:
> On 2016/04/06 16:03:18, Michael Achenbach wrote:
> > s390x has 64 while s390 has 31 bits (yes 1).
> Wow! How does this work?

The internet has probably a lot of reading material :)
Like: https://en.wikipedia.org/wiki/IBM_ESA/390

[Michael Achenbach, 2016-04-06 18:12:06]

The CQ bit was checked by machenbach@chromium.org

[commit-bot: I haz the power, 2016-04-06 18:12:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1862083002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1862083002/20001

[commit-bot: I haz the power, 2016-04-06 18:16:10]

Description was changed from

==========
V8: Add s390 bots.

BUG=595733
==========

to

==========
V8: Add s390 bots.

BUG=595733

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299742
==========

[commit-bot: I haz the power, 2016-04-06 18:16:11]

Committed patchset #2 (id:20001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=299742