third_party/WebKit/Source/web/AssociatedURLLoader.h - Issue 1862073002: Let AssociatedURLLoader listen to destruction of the Document used for loading

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/AssociatedURLLoader.h

Issue 1862073002: Let AssociatedURLLoader listen to destruction of the Document used for loading (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Prevent documentStopped() call after destruction of AssociatedURLLoader Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/web/AssociatedURLLoader.h

diff --git a/third_party/WebKit/Source/web/AssociatedURLLoader.h b/third_party/WebKit/Source/web/AssociatedURLLoader.h

index 4f22667855cf4999bb79e569a1d85b6fbfec67a1..5c423755b9a5daae6263e4897ffbf1542f52ced5 100644

--- a/third_party/WebKit/Source/web/AssociatedURLLoader.h

+++ b/third_party/WebKit/Source/web/AssociatedURLLoader.h

@@ -57,13 +57,14 @@ public:

void setDefersLoading(bool) override;

void setLoadingTaskRunner(blink::WebTaskRunner*) override;

-private:

+ void documentStopped();

+private:

class ClientAdapter;

+ class DocumentWatcher;

- Persistent<WebLocalFrameImpl> m_frameImpl;

+ Persistent<DocumentWatcher> m_watcher;

WebURLLoaderOptions m_options;

- WebURLLoaderClient* m_client;

OwnPtr<ClientAdapter> m_clientAdapter;

OwnPtr<DocumentThreadableLoader> m_loader;

};

« no previous file with comments | « no previous file | third_party/WebKit/Source/web/AssociatedURLLoader.cpp » ('j') | third_party/WebKit/Source/web/AssociatedURLLoader.cpp » ('J')