[heap] Don't use black pages for map, code and, lo space. Instead color objects black.

src/heap/heap.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/heap/heap.h"
 
 #include "src/accessors.h"
 #include "src/api.h"
 #include "src/ast/scopeinfo.h"
 #include "src/base/bits.h"
@@ skipping 4211 matching lines @@
                       "idle notification: finalize incremental marking");
     return true;
   }
   return false;
 }
 
 void Heap::RegisterReservationsForBlackAllocation(Reservation* reservations) {
   // TODO(hpayer): We do not have to iterate reservations on black objects
   // for marking. We just have to execute the special visiting side effect
   // code that adds objects to global data structures, e.g. for array buffers.
+
+  // Code space, map space, and large object space do not use black pages.
+  // Hence we have to color all objects of the reservation first black to avoid
+  // unnecessary marking deque load.
   if (incremental_marking()->black_allocation()) {
+    for (int i = CODE_SPACE; i < Serializer::kNumberOfSpaces; i++) {
+      const Heap::Reservation& res = reservations[i];
+      for (auto& chunk : res) {
+        Address addr = chunk.start;
+        while (addr < chunk.end) {
+          HeapObject* obj = HeapObject::FromAddress(addr);
+          if (i != OLD_SPACE) {

[ulan, 2016/04/06 16:44:43]

DCHECK_NE(i, OLD_SPACE) because loop starts from CODE_SPACE.

[Hannes Payer (out of office), 2016/04/06 21:23:51]

Done.

+            Marking::MarkBlack(Marking::MarkBitFrom(obj));
+            MemoryChunk::IncrementLiveBytesFromGC(obj, obj->Size());
+          }
+          addr += obj->Size();
+        }
+      }
+    }
     for (int i = OLD_SPACE; i < Serializer::kNumberOfSpaces; i++) {
       const Heap::Reservation& res = reservations[i];
       for (auto& chunk : res) {
         Address addr = chunk.start;
         while (addr < chunk.end) {
           HeapObject* obj = HeapObject::FromAddress(addr);
           incremental_marking()->IterateBlackObject(obj);
           addr += obj->Size();
         }
       }
@@ skipping 2182 matching lines @@
 }
 
 
 // static
 int Heap::GetStaticVisitorIdForMap(Map* map) {
   return StaticVisitorBase::GetVisitorId(map);
 }
 
 }  // namespace internal
 }  // namespace v8