[heap] Don't use black pages for map, code and, lo space. Instead color objects black.

[heap] Don't use black pages for map, code and, lo space. Instead color objects black.

This reduced fragmentation in spaces where black pages are not a requirement. The only spaces where we need black pages is old space, because of allocation folding and fast inline allocation in generated code.

BUG=chromium:599174
LOG=n

Committed: https://crrev.com/d0151bfb137fac378a93703f86f2ac0c4f68cf3a
Cr-Commit-Position: refs/heads/master@{#35315}

[Hannes Payer (out of office), 2016-04-06 15:53:43]

Description was changed from

==========
[heap] Don't use black pages for map, code and, lo space. Instead color objects
black.

BUG=599174
LOG=n
==========

to

==========
[heap] Don't use black pages for map, code and, lo space. Instead color objects
black.

BUG=chromium:599174
LOG=n
==========

[Hannes Payer (out of office), 2016-04-06 15:59:04]

Description was changed from

==========
[heap] Don't use black pages for map, code and, lo space. Instead color objects
black.

BUG=chromium:599174
LOG=n
==========

to

==========
[heap] Don't use black pages for map, code and, lo space. Instead color objects
black.

This reduced fragmentation in spaces where black pages are not a requirement.
The only spaces where we need black pages is old space, because of allocation
folding and fast inline allocation in generated code.

BUG=chromium:599174
LOG=n
==========

[Hannes Payer (out of office), 2016-04-06 15:59:12]

hpayer@chromium.org changed reviewers:
+ ulan@chromium.org

[ulan, 2016-04-06 16:44:43]

lgtm

https://codereview.chromium.org/1862063002/diff/60001/src/heap/heap.cc
File src/heap/heap.cc (right):

https://codereview.chromium.org/1862063002/diff/60001/src/heap/heap.cc#newcod...
src/heap/heap.cc:4243: if (i != OLD_SPACE) {
DCHECK_NE(i, OLD_SPACE) because loop starts from CODE_SPACE.

https://codereview.chromium.org/1862063002/diff/60001/src/heap/spaces.cc
File src/heap/spaces.cc (right):

https://codereview.chromium.org/1862063002/diff/60001/src/heap/spaces.cc#newc...
src/heap/spaces.cc:1187: identity() != CODE_SPACE && identity() != MAP_SPACE) {
Let's whitelist instead of blacklist, identity() == OLD_SPACE

[Hannes Payer (out of office), 2016-04-06 21:23:51]

https://codereview.chromium.org/1862063002/diff/60001/src/heap/heap.cc
File src/heap/heap.cc (right):

https://codereview.chromium.org/1862063002/diff/60001/src/heap/heap.cc#newcod...
src/heap/heap.cc:4243: if (i != OLD_SPACE) {
On 2016/04/06 at 16:44:43, ulan wrote:
> DCHECK_NE(i, OLD_SPACE) because loop starts from CODE_SPACE.

Done.

[Hannes Payer (out of office), 2016-04-06 21:24:39]

https://codereview.chromium.org/1862063002/diff/60001/src/heap/spaces.cc
File src/heap/spaces.cc (right):

https://codereview.chromium.org/1862063002/diff/60001/src/heap/spaces.cc#newc...
src/heap/spaces.cc:1187: identity() != CODE_SPACE && identity() != MAP_SPACE) {
On 2016/04/06 at 16:44:43, ulan wrote:
> Let's whitelist instead of blacklist, identity() == OLD_SPACE

Done.

[Hannes Payer (out of office), 2016-04-06 21:25:02]

The CQ bit was checked by hpayer@chromium.org

[Hannes Payer (out of office), 2016-04-06 21:25:02]

The patchset sent to the CQ was uploaded after l-g-t-m from ulan@chromium.org
Link to the patchset: https://codereview.chromium.org/1862063002/#ps80001
(title: " ")

[commit-bot: I haz the power, 2016-04-06 21:25:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1862063002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1862063002/80001

[commit-bot: I haz the power, 2016-04-06 21:51:46]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-04-06 21:53:38]

Description was changed from

==========
[heap] Don't use black pages for map, code and, lo space. Instead color objects
black.

This reduced fragmentation in spaces where black pages are not a requirement.
The only spaces where we need black pages is old space, because of allocation
folding and fast inline allocation in generated code.

BUG=chromium:599174
LOG=n
==========

to

==========
[heap] Don't use black pages for map, code and, lo space. Instead color objects
black.

This reduced fragmentation in spaces where black pages are not a requirement.
The only spaces where we need black pages is old space, because of allocation
folding and fast inline allocation in generated code.

BUG=chromium:599174
LOG=n

Committed: https://crrev.com/d0151bfb137fac378a93703f86f2ac0c4f68cf3a
Cr-Commit-Position: refs/heads/master@{#35315}
==========

[commit-bot: I haz the power, 2016-04-06 21:53:39]

Patchset 5 (id:??) landed as
https://crrev.com/d0151bfb137fac378a93703f86f2ac0c4f68cf3a
Cr-Commit-Position: refs/heads/master@{#35315}