Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Unified Diff: third_party/qcms/src/tests/qcms_test_output_trc.c

Issue 1862053002: Reland: [qcms] Fix build_output_lut to return correct data for parametric curves (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Retrieved input gamma for parametric curves. Compute best gamma from data set Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/qcms/src/tests/qcms_test_output_trc.c
diff --git a/third_party/qcms/src/tests/qcms_test_output_trc.c b/third_party/qcms/src/tests/qcms_test_output_trc.c
new file mode 100644
index 0000000000000000000000000000000000000000..091d7b14bd3546ecde8834801f2871ba7b1bc9e0
--- /dev/null
+++ b/third_party/qcms/src/tests/qcms_test_output_trc.c
@@ -0,0 +1,243 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the Chromium LICENSE file.
+
+#include "qcms.h"
+#include "qcms_test_util.h"
+
+#include <math.h>
+#include <stdio.h>
+#include <stdlib.h>
+#include <time.h>
+
+#define PARAMETRIC_CURVE_TYPE 0x70617261 // 'para'
+#define MAX_FLOAT_ERROR 0.000001f
+
+static const float inverse65535 = (float) (1.0 / 65535.0);
+
+extern float clamp_float(float a);
+
+static int get_output_gamma_table(const char *profile_path, uint16_t **table, size_t *size, bool precache)
+{
+ qcms_format_type format = {0, 2}; // RGBA
+ qcms_transform *transform;
+ qcms_profile *profile, *sRGB;
+ int ret = 0;
+
+ profile = qcms_profile_from_path(profile_path);
+ if (!profile) {
+ fprintf(stderr, "Invalid input profile\n");
+ return EXIT_FAILURE;
+ }
+
+ sRGB = qcms_profile_sRGB();
+
+ if (precache) {
+ qcms_profile_precache_output_transform(profile);
+ }
+
+ transform = qcms_transform_create(sRGB, QCMS_DATA_RGBA_8, profile, QCMS_DATA_RGBA_8, QCMS_INTENT_DEFAULT);
+ if (!transform) {
+ fprintf(stderr, "Failed to create colour transform\n");
+ ret = 1;
+ goto RELEASE_PROFILES;
+ }
+
+ *size = qcms_transform_get_output_trc_rgba(transform, profile, QCMS_TRC_USHORT, NULL);
+ *table = malloc(*size * sizeof(uint16_t) * 4);
+ qcms_transform_get_output_trc_rgba(transform, profile, QCMS_TRC_USHORT, *table);
+
+ qcms_transform_release(transform);
+
+ RELEASE_PROFILES:
+ qcms_profile_release(sRGB);
+ qcms_profile_release(profile);
+
+ return ret;
+}
+
+static int get_input_gamma_table(const char *profile_path, uint16_t **table, size_t expected_size)
+{
+ qcms_format_type format = {0, 2}; // RGBA
+ qcms_transform *transform;
+ qcms_profile *profile, *sRGB;
+ size_t size;
+ int ret = 0;
+
+ profile = qcms_profile_from_path(profile_path);
+ if (!profile) {
+ fprintf(stderr, "Invalid input profile\n");
+ return EXIT_FAILURE;
+ }
+
+ sRGB = qcms_profile_sRGB();
+
+ transform = qcms_transform_create(profile, QCMS_DATA_RGBA_8, sRGB, QCMS_DATA_RGBA_8, QCMS_INTENT_DEFAULT);
+ if (!transform) {
+ fprintf(stderr, "Failed to create colour transform\n");
+ ret = 1;
+ goto RELEASE_PROFILES;
+ }
+
+ size = qcms_transform_get_input_trc_rgba(transform, profile, QCMS_TRC_USHORT, NULL);
+ if (size != expected_size) {
+ fprintf(stderr, "Expected input table size (%zu) to match output size (%zu)\n", size, expected_size);
+ size = size > expected_size ? size : expected_size;
+ }
+
+ *table = calloc(size, sizeof(uint16_t) * 4);
+ qcms_transform_get_input_trc_rgba(transform, profile, QCMS_TRC_USHORT, *table);
+
+ qcms_transform_release(transform);
+
+ RELEASE_PROFILES:
+ qcms_profile_release(sRGB);
+ qcms_profile_release(profile);
+
+ return ret;
+}
+
+static int qcms_test_output_trc(size_t width,
+ size_t height,
+ int iterations,
+ const char *in_path,
+ const char *out_path,
+ const int force_software)
+{
+ int err = 0;
+ qcms_profile *profile;
+ uint16_t *gamma_table_out, *gamma_table_out_precache;
+ uint16_t *gamma_table_in;
+ size_t gamma_table_size, gamma_table_size_precache;
+ char file_name[256] = {0,};
+ int i;
+
+ printf("Test qcms output gamma curve integrity with and without precached tables.\n");
+
+ if (!in_path) {
+ fprintf(stderr, "%s: please provide valid ICC profiles via -i option\n", __FUNCTION__);
+ return EXIT_FAILURE;
+ }
+
+ gamma_table_out = NULL;
+ gamma_table_size = 0;
+ if (get_output_gamma_table(in_path, &gamma_table_out, &gamma_table_size, true) != 0) {
+ fprintf(stderr, "Unable to extract output gamma table\n");
+ return EXIT_FAILURE;
+ }
+
+ gamma_table_out_precache = NULL;
+ gamma_table_size_precache = 0;
+ if (get_output_gamma_table(in_path, &gamma_table_out_precache, &gamma_table_size_precache, false) != 0) {
+ fprintf(stderr, "Unable to extract precached output gamma table\n");
+ return EXIT_FAILURE;
+ }
+
+ if (gamma_table_size != gamma_table_size_precache) {
+ fprintf(stderr, "Size mismatch between output table sizes.\n"
+ "Output gamma size = %zu, gamma size with precahce = %zu\n", gamma_table_size, gamma_table_size_precache);
+ free(gamma_table_out);
+ free(gamma_table_out_precache);
+ return EXIT_FAILURE;
+ }
+
+ printf("LUT size = %zu, %zu\n", gamma_table_size, gamma_table_size_precache);
+
+ for (i = 0; i < 4 * gamma_table_size; ++i) {
+ err += abs(gamma_table_out[i] - gamma_table_out_precache[i]);
+ }
+
+ if (err != 0) {
+ fprintf(stderr, "Gamma output total error = %d\n.Aborting.", err);
+
+ free(gamma_table_out);
+ free(gamma_table_out_precache);
+
+ return EXIT_FAILURE;
+ }
+
+ profile = qcms_profile_from_path(in_path);
+ if (!profile) {
+ fprintf(stderr, "Invalid input profile\n");
+
+ free(gamma_table_out);
+ free(gamma_table_out_precache);
+
+ return EXIT_FAILURE;
+ }
+
+ // Check only for red curve for now.
+ if (profile->redTRC->type == PARAMETRIC_CURVE_TYPE) {
+ int type = - (profile->redTRC->count + 1);
+ FILE *gamma_file;
+ uint16_t *p_table_out, *p_table_in;
+ double gamma_aprox_in = 0, gamma_aprox_out = 0;
+ double sum_of_sqares = 0;
+
+ printf("Detected parametric curve type = %d\n", profile->redTRC->count);
+
+ sprintf(file_name, "qcms-test-%ld-parametric-gamma-%s.csv", (long int)time(NULL), profile->description);
+ printf("Writing input and output gamma tables to %s\n", file_name);
+
+ printf("gamma = %.6f, a = %.6f, b = %.6f, c = %.6f, d = %.6f, e = %.6f, f = %.6f\n",
+ profile->redTRC->parameter[0], profile->redTRC->parameter[1], profile->redTRC->parameter[2],
+ profile->redTRC->parameter[3], profile->redTRC->parameter[4], profile->redTRC->parameter[5],
+ profile->redTRC->parameter[6]);
+
+ gamma_file = fopen(file_name, "w");
+ fprintf(gamma_file, "Parametric gamma values for %s\n", profile->description);
+ fprintf(gamma_file, "gamma, a, b, c, d, e, f\n");
+ fprintf(gamma_file, "%.6f, %.6f, %.6f, %.6f, %.6f, %.6f, %.6f\n",
+ profile->redTRC->parameter[0], profile->redTRC->parameter[1], profile->redTRC->parameter[2],
+ profile->redTRC->parameter[3], profile->redTRC->parameter[4], profile->redTRC->parameter[5],
+ profile->redTRC->parameter[6]);
+
+ get_input_gamma_table(in_path, &gamma_table_in, gamma_table_size);
+
+ fprintf(gamma_file, "\n\nInput gamma, Output gamma, LCMS Output gamma, Output gamma error\n");
+
+ p_table_out = gamma_table_out;
+ p_table_in = gamma_table_in;
+
+ for (i = 0; i < gamma_table_size; ++i) {
+ float p = i / (gamma_table_size * 1.0);
+ float reference_out = clamp_float(evaluate_parametric_curve(type, profile->redTRC->parameter, p));
+ float actual_out = *p_table_out * inverse65535;
+ float error_out = fabs(actual_out - reference_out);
+ float input = *p_table_in * inverse65535;
+
+ if (p > MAX_FLOAT_ERROR && input > MAX_FLOAT_ERROR && actual_out > MAX_FLOAT_ERROR) {
+ gamma_aprox_in += log(p) * log(input);
+ gamma_aprox_out += log(p) * log(actual_out);
+ sum_of_sqares += log(p) * log(p);
+ }
+
+ fprintf(gamma_file, "%.6f, %.6f, %6f, %6f\n",input, actual_out, reference_out, error_out);
+
+ p_table_out += 4; // Skip other channels.
+ p_table_in += 4; // Skip other channels.
+ }
+
+ gamma_aprox_in /= sum_of_sqares;
+ gamma_aprox_out /= sum_of_sqares;
+
+ printf("Computed gamma from LUTs:\nInput = %.6lf\nOutput = %.6lf\nAccuracy? = %.6lf\n",
+ gamma_aprox_in, gamma_aprox_out, gamma_aprox_in * gamma_aprox_out);
+
+ free(gamma_table_in);
+ fclose(gamma_file);
+ }
+
+ qcms_profile_release(profile);
+
+ free(gamma_table_out);
+ free(gamma_table_out_precache);
+
+ return err;
+}
+
+struct qcms_test_case qcms_test_output_trc_info = {
+ "qcms_test_output_trc",
+ qcms_test_output_trc,
+ QCMS_TEST_DISABLED
+};

Powered by Google App Engine
This is Rietveld 408576698