src/gpu/vk/GrVkStencilAttachment.h - Issue 1862043002: Refactor to separate backend object lifecycle and GpuResource budget decision

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/gpu/vk/GrVkStencilAttachment.h

Issue 1862043002: Refactor to separate backend object lifecycle and GpuResource budget decision (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: fix unrelated GrBuffer::onGpuMemorySize() lack of override keyword compile error Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/gpu/vk/GrVkStencilAttachment.h

diff --git a/src/gpu/vk/GrVkStencilAttachment.h b/src/gpu/vk/GrVkStencilAttachment.h

index 282fdf76d9409c98df4d6e414741ae66ea7b0a4d..f106c69971e032335bfdd1520924a1a7f7c403f9 100644

--- a/src/gpu/vk/GrVkStencilAttachment.h

+++ b/src/gpu/vk/GrVkStencilAttachment.h

@@ -24,8 +24,7 @@ public:

bool fPacked;

};

- static GrVkStencilAttachment* Create(GrVkGpu* gpu, GrGpuResource::LifeCycle lifeCycle,

- int width, int height,

+ static GrVkStencilAttachment* Create(GrVkGpu* gpu, int width, int height,

int sampleCnt, const Format& format);

~GrVkStencilAttachment() override;

@@ -43,7 +42,6 @@ private:

size_t onGpuMemorySize() const override;

GrVkStencilAttachment(GrVkGpu* gpu,

- GrGpuResource::LifeCycle lifeCycle,

const Format& format,

const GrVkImage::ImageDesc&,

const GrVkImage::Resource*,

« no previous file with comments | « src/gpu/vk/GrVkRenderTarget.cpp ('k') | src/gpu/vk/GrVkStencilAttachment.cpp » ('j') | no next file with comments »