third_party/WebKit/Source/modules/canvas/HTMLCanvasElementModule.cpp - Issue 1862033002: Make OffscreenCanvas Transferable

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/canvas/HTMLCanvasElementModule.cpp

Issue 1862033002: Make OffscreenCanvas Transferable (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address haraken's comments, need bots to test Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/modules/ModulesInitializer.cpp ('K') | « third_party/WebKit/Source/modules/ModulesInitializer.cpp ('k') | third_party/WebKit/Source/modules/canvas/HTMLCanvasElementModuleTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/canvas/HTMLCanvasElementModule.cpp

diff --git a/third_party/WebKit/Source/modules/canvas/HTMLCanvasElementModule.cpp b/third_party/WebKit/Source/modules/canvas/HTMLCanvasElementModule.cpp

index 7988132932fe846834bb47e377a9b4324e3b9a8f..9895e0ede6e0eecc168df6bfa626a2b2f85858ce 100644

--- a/third_party/WebKit/Source/modules/canvas/HTMLCanvasElementModule.cpp

+++ b/third_party/WebKit/Source/modules/canvas/HTMLCanvasElementModule.cpp

@@ -4,6 +4,7 @@

#include "modules/canvas/HTMLCanvasElementModule.h"

+#include "core/dom/DOMNodeIds.h"

#include "core/html/canvas/CanvasContextCreationAttributes.h"

#include "core/html/canvas/CanvasRenderingContext.h"

@@ -24,7 +25,7 @@ OffscreenCanvas* HTMLCanvasElementModule::transferControlToOffscreen(HTMLCanvasE

return nullptr;

}

OffscreenCanvas* offscreenCanvas = OffscreenCanvas::create(canvas.width(), canvas.height());

- offscreenCanvas->setAssociatedCanvas(&canvas);

+ offscreenCanvas->setAssociatedCanvasId(DOMNodeIds::idForNode(&canvas));

return offscreenCanvas;

}