third_party/WebKit/Source/bindings/core/v8/ScriptValueSerializer.h - Issue 1862033002: Make OffscreenCanvas Transferable

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ScriptValueSerializer.h

Issue 1862033002: Make OffscreenCanvas Transferable (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address haraken's comments, need bots to test Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/canvas/resources/OffscreenCanvas-transferable.js ('k') | third_party/WebKit/Source/bindings/core/v8/ScriptValueSerializer.cpp » ('j') | third_party/WebKit/Source/bindings/core/v8/SerializedScriptValue.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/ScriptValueSerializer.h

diff --git a/third_party/WebKit/Source/bindings/core/v8/ScriptValueSerializer.h b/third_party/WebKit/Source/bindings/core/v8/ScriptValueSerializer.h

index 3540474ba0edb830e3f4df7760b44824930554e4..a830f1fd3820bca721160e2197c2cb603dc21a16 100644

--- a/third_party/WebKit/Source/bindings/core/v8/ScriptValueSerializer.h

+++ b/third_party/WebKit/Source/bindings/core/v8/ScriptValueSerializer.h

@@ -143,6 +143,7 @@ public:

void writeTransferredMessagePort(uint32_t index);

void writeTransferredArrayBuffer(uint32_t index);

void writeTransferredImageBitmap(uint32_t index);

+ virtual void writeTransferredOffscreenCanvas(uint32_t index, uint32_t width, uint32_t height, uint32_t id) { };

void writeTransferredSharedArrayBuffer(uint32_t index);

void writeObjectReference(uint32_t reference);

void writeObject(uint32_t numProperties);

@@ -208,7 +209,7 @@ public:

JSException

};

- ScriptValueSerializer(SerializedScriptValueWriter&, const Transferables*, WebBlobInfoArray*, BlobDataHandleMap& blobDataHandles, v8::TryCatch&, ScriptState*);

+ ScriptValueSerializer(SerializedScriptValueWriter&, Transferables*, WebBlobInfoArray*, BlobDataHandleMap& blobDataHandles, v8::TryCatch&, ScriptState*);

v8::Isolate* isolate() { return m_scriptState->isolate(); }

v8::Local<v8::Context> context() { return m_scriptState->context(); }

@@ -465,6 +466,7 @@ public:

virtual bool tryGetTransferredMessagePort(uint32_t index, v8::Local<v8::Value>*) = 0;

virtual bool tryGetTransferredArrayBuffer(uint32_t index, v8::Local<v8::Value>*) = 0;

virtual bool tryGetTransferredImageBitmap(uint32_t index, v8::Local<v8::Value>*) = 0;

+ virtual bool tryGetTransferredOffscreenCanvas(uint32_t index, uint32_t width, uint32_t height, uint32_t id, v8::Local<v8::Value>*) { return true; };

virtual bool tryGetTransferredSharedArrayBuffer(uint32_t index, v8::Local<v8::Value>*) = 0;

virtual bool newSparseArray(uint32_t length) = 0;

virtual bool newDenseArray(uint32_t length) = 0;