third_party/WebKit/Source/bindings/core/v8/TransferableExtractor.h - Issue 1862033002: Make OffscreenCanvas Transferable

Side by Side Diff: third_party/WebKit/Source/bindings/core/v8/TransferableExtractor.h

Issue 1862033002: Make OffscreenCanvas Transferable (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase, compiles but crashes some layout tests Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/SerializedScriptValueFactory.cpp ('k') | third_party/WebKit/Source/bindings/core/v8/TransferableExtractor.cpp » ('j') | third_party/WebKit/Source/bindings/modules/v8/ScriptValueSerializerForModules.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef TransferableExtractor_h

	6 #define TransferableExtractor_h

	7

	8 #include "bindings/core/v8/ExceptionState.h"

	9 #include "bindings/core/v8/SerializedScriptValue.h"

	10 #include "core/CoreExport.h"

	11 #include "wtf/PassOwnPtr.h"

	12 #include <v8.h>

	13

	14 namespace blink {

	15

	16 class CORE_EXPORT TransferableExtractor {
	haraken 2016/04/19 00:48:10 Do you have a plan to add more extractors? It look Do you have a plan to add more extractors? It looks a bit overkilling to introduce this class only for TransferableOffscreenCanvasExtractor. If you only need the TransferableOffscreenCanvasExtractor, can you register the extractor on SerializedScriptValueForModules (and use the extractor in SerializedScriptValueForModules)? xidachen 2016/04/19 15:29:50 The reason to have this class here is that we cann Show quoted text On 2016/04/19 00:48:10, haraken wrote: > > Do you have a plan to add more extractors? It looks a bit overkilling to > introduce this class only for TransferableOffscreenCanvasExtractor. > > If you only need the TransferableOffscreenCanvasExtractor, can you register the > extractor on SerializedScriptValueForModules (and use the extractor in > SerializedScriptValueForModules)? The reason to have this class here is that we cannot foresee the future. Just like when we add the ArrayBuffer and ImageBitmap to be transferable, we should have created a Transferables class at that time. As worker gets more and more popular, I certainly believe that there will be other transferable types in the future because transfer an object involves zero copy. These transferable types could live under modules/. So this TransferableExtractor provides a place holder for all types in modules that are to be "transferable" in the future. haraken 2016/04/20 01:18:24 If you don't have a concrete plan now, I'd prefer Show quoted text On 2016/04/19 15:29:50, xidachen wrote: > On 2016/04/19 00:48:10, haraken wrote: > > > > Do you have a plan to add more extractors? It looks a bit overkilling to > > introduce this class only for TransferableOffscreenCanvasExtractor. > > > > If you only need the TransferableOffscreenCanvasExtractor, can you register > the > > extractor on SerializedScriptValueForModules (and use the extractor in > > SerializedScriptValueForModules)? > > > The reason to have this class here is that we cannot foresee the future. Just > like when we add the ArrayBuffer and ImageBitmap to be transferable, we should > have created a Transferables class at that time. > > As worker gets more and more popular, I certainly believe that there will be > other transferable types in the future because transfer an object involves zero > copy. These transferable types could live under modules/. So this > TransferableExtractor provides a place holder for all types in modules that are > to be "transferable" in the future. If you don't have a concrete plan now, I'd prefer keeping the code as simple as possible. We can generalize the mechanism when we actually need it.
	17 public:

	18 virtual ~TransferableExtractor() { }

	19 static void registerTransferableExtractor(PassOwnPtr<TransferableExtractor>) ;

	20 static const Vector<OwnPtr<TransferableExtractor>>& getExtractors();

	21 virtual bool extract(v8::Local<v8::Value>, v8::Isolate*, Transferables&, Exc eptionState&, const unsigned) = 0;

	22 };

	23

	24 } // namespace blink

	25

	26 #endif // TransferableExtractor_h

OLD	NEW