Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Unified Diff: test/cctest/test-log-stack-tracer.cc

Issue 18620002: Do not store fp and sp values in TickSample (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Removed fp Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: test/cctest/test-log-stack-tracer.cc
diff --git a/test/cctest/test-log-stack-tracer.cc b/test/cctest/test-log-stack-tracer.cc
index 4333498d8b1fe987bd49c50a7f438de2c311790d..c7b1a223cf0806ff2b27ca18c2aea1f7a006217a 100644
--- a/test/cctest/test-log-stack-tracer.cc
+++ b/test/cctest/test-log-stack-tracer.cc
@@ -51,6 +51,7 @@ using v8::internal::Address;
using v8::internal::Handle;
using v8::internal::Isolate;
using v8::internal::JSFunction;
+using v8::internal::RegisterState;
using v8::internal::TickSample;
@@ -65,11 +66,12 @@ static void InitTraceEnv(TickSample* sample) {
static void DoTrace(Address fp) {
- trace_env.sample->fp = fp;
+ RegisterState regs;
+ regs.fp = fp;
// sp is only used to define stack high bound
- trace_env.sample->sp =
+ regs.sp =
reinterpret_cast<Address>(trace_env.sample) - 10240;
- trace_env.sample->Trace(Isolate::Current());
+ trace_env.sample->Init(Isolate::Current(), regs);
}
« src/frames.cc ('K') | « src/sampler.cc ('k') | test/mjsunit/tools/tickprocessor-test.log » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698