Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Side by Side Diff: src/frames.cc

Issue 18620002: Do not store fp and sp values in TickSample (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Removed fp Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/frames.h ('k') | src/log.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 198 matching lines...) Expand 10 before | Expand all | Expand 10 after
209 return (script->IsScript() && 209 return (script->IsScript() &&
210 Script::TYPE_NATIVE != Script::cast(script)->type()->value()); 210 Script::TYPE_NATIVE != Script::cast(script)->type()->value());
211 } 211 }
212 212
213 213
214 // ------------------------------------------------------------------------- 214 // -------------------------------------------------------------------------
215 215
216 216
217 SafeStackFrameIterator::SafeStackFrameIterator( 217 SafeStackFrameIterator::SafeStackFrameIterator(
218 Isolate* isolate, 218 Isolate* isolate,
219 Address fp, Address sp, Address low_bound, Address high_bound) : 219 Address fp, Address sp, Address js_entry_sp) :
220 StackFrameIteratorBase(isolate, false), 220 StackFrameIteratorBase(isolate, false),
Jakob Kummerow 2013/07/03 14:12:31 nit: while you're here, please move the ':' onto t
yurys 2013/07/03 14:16:41 Done.
221 low_bound_(low_bound), high_bound_(high_bound), 221 low_bound_(sp), high_bound_(js_entry_sp),
222 top_frame_type_(StackFrame::NONE) { 222 top_frame_type_(StackFrame::NONE) {
223 StackFrame::State state; 223 StackFrame::State state;
224 StackFrame::Type type; 224 StackFrame::Type type;
225 ThreadLocalTop* top = isolate->thread_local_top(); 225 ThreadLocalTop* top = isolate->thread_local_top();
226 if (IsValidTop(top)) { 226 if (IsValidTop(top)) {
227 type = ExitFrame::GetStateForFramePointer(Isolate::c_entry_fp(top), &state); 227 type = ExitFrame::GetStateForFramePointer(Isolate::c_entry_fp(top), &state);
228 top_frame_type_ = type; 228 top_frame_type_ = type;
229 } else if (IsValidStackAddress(fp)) { 229 } else if (IsValidStackAddress(fp)) {
230 ASSERT(fp != NULL); 230 ASSERT(fp != NULL);
231 state.fp = fp; 231 state.fp = fp;
(...skipping 1371 matching lines...) Expand 10 before | Expand all | Expand 10 after
1603 ZoneList<StackFrame*> list(10, zone); 1603 ZoneList<StackFrame*> list(10, zone);
1604 for (StackFrameIterator it(isolate); !it.done(); it.Advance()) { 1604 for (StackFrameIterator it(isolate); !it.done(); it.Advance()) {
1605 StackFrame* frame = AllocateFrameCopy(it.frame(), zone); 1605 StackFrame* frame = AllocateFrameCopy(it.frame(), zone);
1606 list.Add(frame, zone); 1606 list.Add(frame, zone);
1607 } 1607 }
1608 return list.ToVector(); 1608 return list.ToVector();
1609 } 1609 }
1610 1610
1611 1611
1612 } } // namespace v8::internal 1612 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/frames.h ('k') | src/log.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698