Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1549)

Side by Side Diff: src/log.cc

Issue 18620002: Do not store fp and sp values in TickSample (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Fixed SIMULATOR compilation Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/frames.cc ('k') | src/sampler.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1346 matching lines...) Expand 10 before | Expand all | Expand 10 after
1357 DeleteArray(parameter_string); 1357 DeleteArray(parameter_string);
1358 msg.WriteToLogFile(); 1358 msg.WriteToLogFile();
1359 } 1359 }
1360 1360
1361 1361
1362 void Logger::TickEvent(TickSample* sample, bool overflow) { 1362 void Logger::TickEvent(TickSample* sample, bool overflow) {
1363 if (!log_->IsEnabled() || !FLAG_prof) return; 1363 if (!log_->IsEnabled() || !FLAG_prof) return;
1364 LogMessageBuilder msg(this); 1364 LogMessageBuilder msg(this);
1365 msg.Append("%s,", kLogEventsNames[TICK_EVENT]); 1365 msg.Append("%s,", kLogEventsNames[TICK_EVENT]);
1366 msg.AppendAddress(sample->pc); 1366 msg.AppendAddress(sample->pc);
1367 msg.Append(',');
1368 msg.AppendAddress(sample->sp);
1369 msg.Append(",%ld", static_cast<int>(OS::Ticks() - epoch_)); 1367 msg.Append(",%ld", static_cast<int>(OS::Ticks() - epoch_));
1370 if (sample->has_external_callback) { 1368 if (sample->has_external_callback) {
1371 msg.Append(",1,"); 1369 msg.Append(",1,");
1372 msg.AppendAddress(sample->external_callback); 1370 msg.AppendAddress(sample->external_callback);
1373 } else { 1371 } else {
1374 msg.Append(",0,"); 1372 msg.Append(",0,");
1375 msg.AppendAddress(sample->tos); 1373 msg.AppendAddress(sample->tos);
1376 } 1374 }
1377 msg.Append(",%d", static_cast<int>(sample->state)); 1375 msg.Append(",%d", static_cast<int>(sample->state));
1378 if (overflow) { 1376 if (overflow) {
(...skipping 433 matching lines...) Expand 10 before | Expand all | Expand 10 after
1812 profiler_ = NULL; 1810 profiler_ = NULL;
1813 } 1811 }
1814 1812
1815 delete ticker_; 1813 delete ticker_;
1816 ticker_ = NULL; 1814 ticker_ = NULL;
1817 1815
1818 return log_->Close(); 1816 return log_->Close();
1819 } 1817 }
1820 1818
1821 } } // namespace v8::internal 1819 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/frames.cc ('k') | src/sampler.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698