Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(922)

Unified Diff: chrome/browser/password_manager/chrome_password_manager_client.cc

Issue 1861973002: Revert of Switch components/password_manager code from IPC messages to Mojo. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/password_manager/chrome_password_manager_client.cc
diff --git a/chrome/browser/password_manager/chrome_password_manager_client.cc b/chrome/browser/password_manager/chrome_password_manager_client.cc
index 144b97ad4b919e698e0bb8903090c793e566d379..719c1f53af7a95065b68846ec5528ea4f4c69c2e 100644
--- a/chrome/browser/password_manager/chrome_password_manager_client.cc
+++ b/chrome/browser/password_manager/chrome_password_manager_client.cc
@@ -33,6 +33,7 @@
#include "components/browser_sync/browser/profile_sync_service.h"
#include "components/password_manager/content/browser/content_password_manager_driver.h"
#include "components/password_manager/content/browser/password_manager_internals_service_factory.h"
+#include "components/password_manager/content/common/credential_manager_messages.h"
#include "components/password_manager/core/browser/browser_save_password_progress_logger.h"
#include "components/password_manager/core/browser/log_manager.h"
#include "components/password_manager/core/browser/log_receiver.h"
@@ -140,7 +141,7 @@
profile_(Profile::FromBrowserContext(web_contents->GetBrowserContext())),
password_manager_(this),
driver_factory_(nullptr),
- credential_manager_impl_(web_contents, this),
+ credential_manager_dispatcher_(web_contents, this),
observer_(nullptr),
credentials_filter_(this,
base::Bind(&GetSyncService, profile_),
@@ -328,7 +329,8 @@
possible_auto_sign_in_->password_value == form.password_value &&
possible_auto_sign_in_->origin == form.origin) {
PromptUserToEnableAutosigninIfNecessary();
- if (form.skip_zero_click && credential_manager_impl_.IsZeroClickAllowed() &&
+ if (form.skip_zero_click &&
+ credential_manager_dispatcher_.IsZeroClickAllowed() &&
GetPasswordStore()) {
autofill::PasswordForm update(form);
update.skip_zero_click = false;
@@ -610,17 +612,3 @@
const {
return log_manager_.get();
}
-
-// static
-void ChromePasswordManagerClient::BindCredentialManager(
- content::RenderFrameHost* render_frame_host,
- password_manager::mojom::CredentialManagerRequest request) {
- content::WebContents* web_contents =
- content::WebContents::FromRenderFrameHost(render_frame_host);
- DCHECK(web_contents);
-
- ChromePasswordManagerClient* instance =
- ChromePasswordManagerClient::FromWebContents(web_contents);
- DCHECK(instance);
- instance->credential_manager_impl_.BindRequest(std::move(request));
-}

Powered by Google App Engine
This is Rietveld 408576698