|
Revert of Switch components/password_manager code from IPC messages to Mojo. (patchset #28 id:550001 of https://codereview.chromium.org/1762603002/ )
Reason for revert:
Breaks Android GN (dbg) build. (Which is strange)
https://build.chromium.org/p/chromium.linux/builders/Android%20GN%20%28dbg%29/builds/20233
util.build_utils.CalledProcessError: Command failed: ( cd /b/build/slave/Android_GN__dbg_/build/src/out/Debug; javac -g -encoding UTF-8 -classpath lib.java/base/base_java.interface.jar:lib.java/mojo/public/java/bindings.interface.jar:lib.java/mojo/public/java/system.interface.jar -sourcepath '' -bootclasspath lib.java/android.interface.jar -source 1.7 -target 1.7 -Xlint:unchecked -Xlint:deprecation -d /tmp/tmpZ5Cfbk/classes /tmp/tmpZ5Cfbk/java/org/chromium/mojom/password_manager/mojom/CredentialManager.java /tmp/tmpZ5Cfbk/java/org/chromium/mojom/password_manager/mojom/CredentialManager_Internal.java /tmp/tmpZ5Cfbk/java/org/chromium/mojom/password_manager/mojom/CredentialType.java /tmp/tmpZ5Cfbk/java/org/chromium/mojom/password_manager/mojom/CredentialManagerError.java /tmp/tmpZ5Cfbk/java/org/chromium/mojom/password_manager/mojom/CredentialInfo.java )
/tmp/tmpZ5Cfbk/java/org/chromium/mojom/password_manager/mojom/CredentialInfo.java:37: error: package org.chromium.mojom.url.mojom does not exist
public org.chromium.mojom.url.mojom.Origin federation;
^
/tmp/tmpZ5Cfbk/java/org/chromium/mojom/password_manager/mojom/CredentialInfo.java:205: error: package org.chromium.mojom.url.mojom does not exist
result.federation = org.chromium.mojom.url.mojom.Origin.decode(decoder1);
^
2 errors
Original issue's description:
> Switch components/password_manager code from IPC messages to Mojo.
>
> Replace credential_manager_messages.h IPC to Mojo service.
>
> BUG= 582391
>
> Committed: https://crrev.com/d20fb918841354a75546fa38b5307aaba117598b
> Cr-Commit-Position: refs/heads/master@{#385369}
TBR=jochen@chromium.org,amistry@chromium.org,jam@chromium.org,rockot@chromium.org,sammc@chromium.org,tsepez@chromium.org,vabr@chromium.org,leon.han@intel.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 582391
Committed: https://crrev.com/47eba728977fd6d854c1000020d51f6af701c830
Cr-Commit-Position: refs/heads/master@{#385371}
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+2078 lines, -2223 lines) |
Patch |
 |
M |
chrome/browser/chrome_content_browser_client.cc
|
View
|
|
2 chunks |
+0 lines, -8 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/password_manager/chrome_password_manager_client.h
|
View
|
|
3 chunks |
+3 lines, -9 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/password_manager/chrome_password_manager_client.cc
|
View
|
|
4 chunks |
+4 lines, -16 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/password_manager/chrome_password_manager_client_unittest.cc
|
View
|
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
 |
M |
chrome/chrome_common.gypi
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
chrome/common/BUILD.gn
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
components/BUILD.gn
|
View
|
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
 |
M |
components/components_tests.gyp
|
View
|
|
2 chunks |
+2 lines, -1 line |
0 comments
|
Download
|
 |
M |
components/password_manager.gypi
|
View
|
|
4 chunks |
+17 lines, -38 lines |
0 comments
|
Download
|
 |
M |
components/password_manager/content/DEPS
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
components/password_manager/content/browser/BUILD.gn
|
View
|
|
3 chunks |
+4 lines, -6 lines |
0 comments
|
Download
|
 |
M |
components/password_manager/content/browser/DEPS
|
View
|
|
1 chunk |
+0 lines, -2 lines |
0 comments
|
Download
|
 |
A |
components/password_manager/content/browser/credential_manager_dispatcher.h
|
View
|
|
1 chunk |
+129 lines, -0 lines |
0 comments
|
Download
|
 |
A |
components/password_manager/content/browser/credential_manager_dispatcher.cc
|
View
|
|
1 chunk |
+283 lines, -0 lines |
0 comments
|
Download
|
 |
A |
components/password_manager/content/browser/credential_manager_dispatcher_unittest.cc
|
View
|
|
1 chunk |
+1164 lines, -0 lines |
0 comments
|
Download
|
 |
D |
components/password_manager/content/browser/credential_manager_impl.h
|
View
|
|
1 chunk |
+0 lines, -126 lines |
0 comments
|
Download
|
 |
D |
components/password_manager/content/browser/credential_manager_impl.cc
|
View
|
|
1 chunk |
+0 lines, -272 lines |
0 comments
|
Download
|
 |
D |
components/password_manager/content/browser/credential_manager_impl_unittest.cc
|
View
|
|
1 chunk |
+0 lines, -1122 lines |
0 comments
|
Download
|
 |
A |
components/password_manager/content/common/BUILD.gn
|
View
|
|
1 chunk |
+22 lines, -0 lines |
0 comments
|
Download
|
 |
A |
components/password_manager/content/common/DEPS
|
View
|
|
1 chunk |
+4 lines, -0 lines |
0 comments
|
Download
|
 |
A |
components/password_manager/content/common/OWNERS
|
View
|
|
1 chunk |
+13 lines, -0 lines |
0 comments
|
Download
|
 |
A |
components/password_manager/content/common/credential_manager_content_utils.h
|
View
|
|
1 chunk |
+22 lines, -0 lines |
0 comments
|
Download
|
 |
A |
components/password_manager/content/common/credential_manager_content_utils.cc
|
View
|
|
1 chunk |
+36 lines, -0 lines |
0 comments
|
Download
|
 |
A |
components/password_manager/content/common/credential_manager_message_generator.h
|
View
|
|
1 chunk |
+7 lines, -0 lines |
0 comments
|
Download
|
 |
A |
components/password_manager/content/common/credential_manager_message_generator.cc
|
View
|
|
1 chunk |
+33 lines, -0 lines |
0 comments
|
Download
|
 |
A |
components/password_manager/content/common/credential_manager_messages.h
|
View
|
|
1 chunk |
+86 lines, -0 lines |
0 comments
|
Download
|
 |
D |
components/password_manager/content/public/cpp/BUILD.gn
|
View
|
|
1 chunk |
+0 lines, -23 lines |
0 comments
|
Download
|
 |
D |
components/password_manager/content/public/cpp/type_converters.h
|
View
|
|
1 chunk |
+0 lines, -51 lines |
0 comments
|
Download
|
 |
D |
components/password_manager/content/public/cpp/type_converters.cc
|
View
|
|
1 chunk |
+0 lines, -128 lines |
0 comments
|
Download
|
 |
D |
components/password_manager/content/public/interfaces/BUILD.gn
|
View
|
|
1 chunk |
+0 lines, -14 lines |
0 comments
|
Download
|
 |
D |
components/password_manager/content/public/interfaces/OWNERS
|
View
|
|
1 chunk |
+0 lines, -13 lines |
0 comments
|
Download
|
 |
D |
components/password_manager/content/public/interfaces/credential_manager.mojom
|
View
|
|
1 chunk |
+0 lines, -44 lines |
0 comments
|
Download
|
 |
M |
components/password_manager/content/renderer/BUILD.gn
|
View
|
|
2 chunks |
+4 lines, -4 lines |
0 comments
|
Download
|
 |
M |
components/password_manager/content/renderer/DEPS
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
 |
M |
components/password_manager/content/renderer/credential_manager_client.h
|
View
|
|
3 chunks |
+27 lines, -4 lines |
0 comments
|
Download
|
 |
M |
components/password_manager/content/renderer/credential_manager_client.cc
|
View
|
|
4 chunks |
+92 lines, -161 lines |
0 comments
|
Download
|
 |
M |
components/password_manager/content/renderer/credential_manager_client_browsertest.cc
|
View
|
|
6 chunks |
+92 lines, -122 lines |
0 comments
|
Download
|
 |
M |
components/password_manager/core/browser/credential_manager_pending_request_task.h
|
View
|
|
5 chunks |
+5 lines, -10 lines |
0 comments
|
Download
|
 |
M |
components/password_manager/core/browser/credential_manager_pending_request_task.cc
|
View
|
|
6 chunks |
+7 lines, -7 lines |
0 comments
|
Download
|
 |
M |
components/password_manager/core/common/credential_manager_types.h
|
View
|
|
2 chunks |
+1 line, -2 lines |
0 comments
|
Download
|
 |
M |
components/password_manager/core/common/credential_manager_types.cc
|
View
|
|
1 chunk |
+2 lines, -10 lines |
0 comments
|
Download
|
 |
M |
content/content_common_mojo_bindings.gyp
|
View
|
|
2 chunks |
+4 lines, -4 lines |
0 comments
|
Download
|
 |
M |
ios/chrome/browser/passwords/credential_manager.h
|
View
|
|
2 chunks |
+2 lines, -7 lines |
0 comments
|
Download
|
 |
M |
ios/chrome/browser/passwords/credential_manager.mm
|
View
|
|
6 chunks |
+7 lines, -15 lines |
0 comments
|
Download
|
 |
M |
ipc/ipc_message_start.h
|
View
|
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
Total messages: 6 (2 generated)
|