Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(372)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1861963003: Delay copying abstract code to avoid failing in the heap verifier (Closed)

Created:
4 years, 8 months ago by Toon Verwaest
Modified:
4 years, 8 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Delay copying abstract code to avoid failing in the heap verifier BUG= Committed: https://crrev.com/6ac509de6e334bd6734fafb50f4a53726bec477a Cr-Commit-Position: refs/heads/master@{#35306}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -4 lines) Patch
M src/factory.cc View 1 chunk +9 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Toon Verwaest
ptal
4 years, 8 months ago (2016-04-06 13:50:08 UTC) #2
Jarin
lgtm
4 years, 8 months ago (2016-04-06 13:55:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1861963003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1861963003/1
4 years, 8 months ago (2016-04-06 13:56:15 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-06 14:33:23 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-06 14:34:21 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/6ac509de6e334bd6734fafb50f4a53726bec477a
Cr-Commit-Position: refs/heads/master@{#35306}

Powered by Google App Engine
This is Rietveld 408576698