third_party/agg23/0000-bug-466.patch - Issue 1861963002: Fix an infinite loop in agg's stroke_calc_arc().

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/agg23/0000-bug-466.patch

Issue 1861963002: Fix an infinite loop in agg's stroke_calc_arc(). (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 diff --git a/third_party/agg23/agg_math_stroke.h b/third_party/agg23/agg_math_st roke.h

	2 index 6d7ba8a..2b06b1b 100644

	3 --- a/third_party/agg23/agg_math_stroke.h

	4 +++ b/third_party/agg23/agg_math_stroke.h

	5 @@ -60,28 +60,30 @@ void stroke_calc_arc(VertexConsumer& out_vertices,

	6 }

	7 da = FXSYS_acos(width / (width + ((1.0f / 8) / approximation_scale))) * 2;

	8 out_vertices.add(coord_type(x + dx1, y + dy1));

	9 - if(!ccw) {

	10 - if(a1 > a2) {

	11 - a2 += 2 * FX_PI;

	12 + if (da > 0) {

	13 + if (!ccw) {

	14 + if (a1 > a2) {

	15 + a2 += 2 * FX_PI;

	16 }

	17 a2 -= da / 4;

	18 a1 += da;

	19 - while(a1 < a2) {

	20 + while (a1 < a2) {

	21 out_vertices.add(coord_type(x + (width * FXSYS_cos(a1)),

	22 y + (width * FXSYS_sin(a1))));

	23 - a1 += da;

	24 + a1 += da;

	25 }

	26 - } else {

	27 - if(a1 < a2) {

	28 - a2 -= 2 * FX_PI;

	29 + } else {

	30 + if (a1 < a2) {

	31 + a2 -= 2 * FX_PI;

	32 }

	33 a2 += da / 4;

	34 a1 -= da;

	35 - while(a1 > a2) {

	36 + while (a1 > a2) {

	37 out_vertices.add(coord_type(x + (width * FXSYS_cos(a1)),

	38 y + (width * FXSYS_sin(a1))));

	39 - a1 -= da;

	40 + a1 -= da;

	41 }

	42 + }

	43 }

	44 out_vertices.add(coord_type(x + dx2, y + dy2));

	45 }

OLD	NEW

« no previous file with comments | « no previous file | third_party/agg23/README.pdfium » ('j') | no next file with comments »