Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(526)

Issue 186193005: Move resource_loader_bridge to content/public/child/ (Closed)

Created:
6 years, 9 months ago by pilgrim_google
Modified:
6 years, 8 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, chromium-apps-reviews_chromium.org, darin-cc_chromium.org, jam, extensions-reviews_chromium.org, jamesr
Visibility:
Public.

Description

Move resource_loader_bridge to content/public/child/ BUG=338338

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+117 lines, -402 lines) Patch
M chrome/renderer/chrome_render_process_observer.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/renderer/extensions/extension_localization_peer.h View 2 chunks +8 lines, -10 lines 0 comments Download
M chrome/renderer/extensions/extension_localization_peer.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/renderer/extensions/extension_localization_peer_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/renderer/security_filter_peer.h View 4 chunks +13 lines, -13 lines 0 comments Download
M chrome/renderer/security_filter_peer.cc View 4 chunks +13 lines, -17 lines 0 comments Download
M content/child/blink_platform_impl.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/child/blink_platform_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/child/child_thread.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/child/child_thread.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/child/npapi/plugin_url_fetcher.h View 4 chunks +4 lines, -4 lines 0 comments Download
M content/child/npapi/plugin_url_fetcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/child/resource_dispatcher.h View 4 chunks +6 lines, -6 lines 0 comments Download
M content/child/resource_dispatcher.cc View 3 chunks +2 lines, -4 lines 0 comments Download
M content/child/resource_dispatcher_unittest.cc View 2 chunks +1 line, -2 lines 0 comments Download
M content/child/web_url_loader_impl.cc View 3 chunks +1 line, -2 lines 0 comments Download
M content/child/webkitplatformsupport_impl.h View 1 chunk +2 lines, -3 lines 0 comments Download
M content/child/webkitplatformsupport_impl.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M content/content_child.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M content/public/child/resource_dispatcher_delegate.h View 2 chunks +5 lines, -5 lines 0 comments Download
A + content/public/child/resource_loader_bridge.h View 9 chunks +30 lines, -25 lines 4 comments Download
A + content/public/child/resource_loader_bridge.cc View 3 chunks +4 lines, -5 lines 0 comments Download
M content/test/test_webkit_platform_support.h View 1 chunk +2 lines, -3 lines 0 comments Download
M content/test/test_webkit_platform_support.cc View 1 chunk +2 lines, -3 lines 0 comments Download
D webkit/child/resource_loader_bridge.h View 1 chunk +0 lines, -237 lines 0 comments Download
D webkit/child/resource_loader_bridge.cc View 1 chunk +0 lines, -37 lines 0 comments Download
M webkit/child/webkit_child.gyp View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
pilgrim_google
6 years, 9 months ago (2014-03-04 17:54:26 UTC) #1
jam
https://codereview.chromium.org/186193005/diff/1/content/public/child/resource_loader_bridge.h File content/public/child/resource_loader_bridge.h (right): https://codereview.chromium.org/186193005/diff/1/content/public/child/resource_loader_bridge.h#newcode42 content/public/child/resource_loader_bridge.h:42: class ResourceLoaderBridge { This class was originally created to ...
6 years, 9 months ago (2014-03-04 20:36:03 UTC) #2
tfarina
What is the status of this CL? We need to move this, to unblock the ...
6 years, 9 months ago (2014-03-20 00:22:25 UTC) #3
pilgrim_google
On 2014/03/20 00:22:25, tfarina wrote: > What is the status of this CL? > > ...
6 years, 9 months ago (2014-03-20 14:12:33 UTC) #4
tfarina
On 2014/03/20 14:12:33, pilgrim_google wrote: > On 2014/03/20 00:22:25, tfarina wrote: > > What is ...
6 years, 9 months ago (2014-03-20 16:06:03 UTC) #5
tfarina
First part is here -> https://codereview.chromium.org/207603003/
6 years, 9 months ago (2014-03-21 03:44:00 UTC) #6
tfarina
Step 2 - https://codereview.chromium.org/216913002/
6 years, 9 months ago (2014-03-28 12:21:40 UTC) #7
tfarina
Step 3 - https://codereview.chromium.org/218973002/
6 years, 8 months ago (2014-03-31 04:15:06 UTC) #8
tfarina
6 years, 8 months ago (2014-04-05 02:04:15 UTC) #9
Message was sent while issue was closed.
Step 4 - https://codereview.chromium.org/226273005/

Powered by Google App Engine
This is Rietveld 408576698