Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1861923002:
Mac h264: Retain CVPixelBuffer inside GLImageIOSurface (Closed)
|
Created:
4 years, 8 months ago by ccameron Modified:
4 years, 8 months ago CC:
reveman, chromium-reviews, darin-cc_chromium.org, feature-media-reviews_chromium.org, jam, mcasas+watch_chromium.org, piman+watch_chromium.org, posciak+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionMac h264: Retain CVPixelBuffer inside GLImageIOSurface
CVPixelBuffers wrap IOSurfaces, and if the owning CVPixelBuffer goes
away, then the IOSurface can end up being discarded.
Adding this path to retain the CVPixelBuffer in the GLImage ensures
that the GLImage will continue to contain valid contents.
BUG=594452
Committed: https://crrev.com/95977a2105324fb9a790db999441bd5891c4e671
Cr-Commit-Position: refs/heads/master@{#386027}
Patch Set 1 #
Total comments: 2
Patch Set 2 : Include order #Patch Set 3 : Fix assert #
Dependent Patchsets: Messages
Total messages: 31 (16 generated)
ccameron@chromium.org changed reviewers: + reveman@chromium.org, sandersd@chromium.org
Adding sandersd@ for media/ Adding avi@ for ui/ (should I put myself in that OWNER list?) Adding reveman@ for GLImage FYI
ccameron@chromium.org changed reviewers: + avi@chromium.org
ccameron@chromium.org changed reviewers: + avi@chromium.org
Actually adding avi@ for ui/
Actually adding avi@ for ui/
lgtm
lgtm
lgtm https://codereview.chromium.org/1861923002/diff/1/ui/gl/gl_image_io_surface.h File ui/gl/gl_image_io_surface.h (right): https://codereview.chromium.org/1861923002/diff/1/ui/gl/gl_image_io_surface.h... ui/gl/gl_image_io_surface.h:9: #include <CoreVideo/CVPixelBuffer.h> Alphabetical?
Thanks! https://codereview.chromium.org/1861923002/diff/1/ui/gl/gl_image_io_surface.h File ui/gl/gl_image_io_surface.h (right): https://codereview.chromium.org/1861923002/diff/1/ui/gl/gl_image_io_surface.h... ui/gl/gl_image_io_surface.h:9: #include <CoreVideo/CVPixelBuffer.h> On 2016/04/06 16:49:52, Avi wrote: > Alphabetical? Oops -- done.
The CQ bit was checked by ccameron@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from avi@chromium.org, reveman@chromium.org, sandersd@chromium.org Link to the patchset: https://codereview.chromium.org/1861923002/#ps20001 (title: "Include order")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1861923002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1861923002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by ccameron@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from avi@chromium.org, reveman@chromium.org, sandersd@chromium.org Link to the patchset: https://codereview.chromium.org/1861923002/#ps40001 (title: "Fix assert")
The CQ bit was unchecked by ccameron@chromium.org
The CQ bit was checked by ccameron@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from avi@chromium.org, reveman@chromium.org, sandersd@chromium.org Link to the patchset: https://codereview.chromium.org/1861923002/#ps40001 (title: "Fix assert")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1861923002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1861923002/40001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by ccameron@chromium.org
The CQ bit was unchecked by ccameron@chromium.org
Err... I'll wait until after 5pm to flip the commit bit -- I want one build which only has the speculative-deadlock-fix in it (crossing fingers that that will fix the hangs)
The CQ bit was checked by ccameron@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1861923002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1861923002/40001
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Mac h264: Retain CVPixelBuffer inside GLImageIOSurface CVPixelBuffers wrap IOSurfaces, and if the owning CVPixelBuffer goes away, then the IOSurface can end up being discarded. Adding this path to retain the CVPixelBuffer in the GLImage ensures that the GLImage will continue to contain valid contents. BUG=594452 ========== to ========== Mac h264: Retain CVPixelBuffer inside GLImageIOSurface CVPixelBuffers wrap IOSurfaces, and if the owning CVPixelBuffer goes away, then the IOSurface can end up being discarded. Adding this path to retain the CVPixelBuffer in the GLImage ensures that the GLImage will continue to contain valid contents. BUG=594452 Committed: https://crrev.com/95977a2105324fb9a790db999441bd5891c4e671 Cr-Commit-Position: refs/heads/master@{#386027} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/95977a2105324fb9a790db999441bd5891c4e671 Cr-Commit-Position: refs/heads/master@{#386027} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
