Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 1861903002: mojo leveldb: Add an iteration interface. (Closed)

Created:
4 years, 8 months ago by Elliot Glaysher
Modified:
4 years, 8 months ago
Reviewers:
jam
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mojo leveldb: Add an iteration interface. This adds iteration support to the mojo:leveldb interface, and builds a compatibility iterator that synchronously blocks for data so that we don't have to rewrite everything to the asynchronous style all at once. BUG=586194 Committed: https://crrev.com/6060a04b7320166f8fad82f39df7969044ab253b Cr-Commit-Position: refs/heads/master@{#385854}

Patch Set 1 #

Patch Set 2 : Hopefully fix the gyp build. #

Patch Set 3 : Brute force fix cast. #

Patch Set 4 : Remember to free the remote iterator. #

Total comments: 1

Patch Set 5 : Rebase + comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+632 lines, -84 lines) Patch
M components/leveldb/BUILD.gn View 3 chunks +4 lines, -2 lines 0 comments Download
M components/leveldb/leveldb.gyp View 1 2 chunks +19 lines, -3 lines 0 comments Download
M components/leveldb/leveldb_database_impl.h View 1 chunk +22 lines, -0 lines 0 comments Download
M components/leveldb/leveldb_database_impl.cc View 2 chunks +116 lines, -1 line 0 comments Download
M components/leveldb/leveldb_service_impl.h View 1 chunk +5 lines, -0 lines 0 comments Download
M components/leveldb/leveldb_service_impl.cc View 3 chunks +17 lines, -10 lines 0 comments Download
M components/leveldb/leveldb_service_unittest.cc View 8 chunks +11 lines, -11 lines 0 comments Download
A components/leveldb/public/cpp/BUILD.gn View 1 chunk +20 lines, -0 lines 0 comments Download
A components/leveldb/public/cpp/remote_iterator.h View 1 chunk +50 lines, -0 lines 0 comments Download
A components/leveldb/public/cpp/remote_iterator.cc View 1 2 3 1 chunk +60 lines, -0 lines 0 comments Download
A components/leveldb/public/cpp/util.h View 1 2 3 4 1 chunk +35 lines, -0 lines 0 comments Download
A components/leveldb/public/cpp/util.cc View 1 2 1 chunk +63 lines, -0 lines 0 comments Download
M components/leveldb/public/interfaces/leveldb.mojom View 2 chunks +64 lines, -1 line 0 comments Download
A components/leveldb/remote_iterator_unittest.cc View 1 chunk +146 lines, -0 lines 0 comments Download
D components/leveldb/util.h View 1 chunk +0 lines, -24 lines 0 comments Download
D components/leveldb/util.cc View 1 chunk +0 lines, -32 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Elliot Glaysher
4 years, 8 months ago (2016-04-06 20:39:09 UTC) #3
jam
lgtm https://codereview.chromium.org/1861903002/diff/60001/components/leveldb/public/cpp/util.h File components/leveldb/public/cpp/util.h (right): https://codereview.chromium.org/1861903002/diff/60001/components/leveldb/public/cpp/util.h#newcode17 components/leveldb/public/cpp/util.h:17: leveldb::Status DatabaseErrorToStatus(DatabaseError e, nit: please add a comment ...
4 years, 8 months ago (2016-04-07 16:06:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1861903002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1861903002/80001
4 years, 8 months ago (2016-04-07 17:48:00 UTC) #7
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 8 months ago (2016-04-07 21:15:10 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-04-07 21:29:31 UTC) #11
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/6060a04b7320166f8fad82f39df7969044ab253b
Cr-Commit-Position: refs/heads/master@{#385854}

Powered by Google App Engine
This is Rietveld 408576698