Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1861813003:
Display device specific up to date message on chromebook. (Closed)
|
Created:
4 years, 8 months ago by malaykeshav Modified:
4 years, 8 months ago CC:
chromium-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionDisplay device specific up to date message on chromebook.
BUG=585277
COMPONENT=ChromeOS, WebUI->help
Committed: https://crrev.com/592a75487c5bb79fe16f643d2cd3fcdb2982a1d7
Cr-Commit-Position: refs/heads/master@{#386475}
Patch Set 1 : #
Total comments: 4
Patch Set 2 : #
Messages
Total messages: 28 (14 generated)
The CQ bit was checked by malaykeshav@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1861813003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1861813003/1
malaykeshav@chromium.org changed reviewers: + jdufault@chromium.org
You also need to update google_chrome_strings [1]. 1: https://code.google.com/p/chromium/codesearch#chromium/src/chrome/app/google_... https://codereview.chromium.org/1861813003/diff/20001/chrome/app/chromium_str... File chrome/app/chromium_strings.grd (right): https://codereview.chromium.org/1861813003/diff/20001/chrome/app/chromium_str... chrome/app/chromium_strings.grd:596: Your <ph name="DEVICE_TYPE">$1<ex>device</ex></ph> is up to date. Chromebook https://codereview.chromium.org/1861813003/diff/20001/chrome/browser/ui/webui... File chrome/browser/ui/webui/help/help_handler.cc (right): https://codereview.chromium.org/1861813003/diff/20001/chrome/browser/ui/webui... chrome/browser/ui/webui/help/help_handler.cc:240: {"upToDate", IDS_UPGRADE_UP_TO_DATE}, Put this next to the other upToDate string insertion, only do it if OS_CHROMEOS is not defined.
Patchset #1 (id:1) has been deleted
The CQ bit was checked by malaykeshav@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1861813003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1861813003/40001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by malaykeshav@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1861813003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1861813003/40001
The CQ bit was unchecked by malaykeshav@chromium.org
https://codereview.chromium.org/1861813003/diff/20001/chrome/app/chromium_str... File chrome/app/chromium_strings.grd (right): https://codereview.chromium.org/1861813003/diff/20001/chrome/app/chromium_str... chrome/app/chromium_strings.grd:596: Your <ph name="DEVICE_TYPE">$1<ex>device</ex></ph> is up to date. On 2016/04/05 23:39:06, jdufault wrote: > Chromebook Done. https://codereview.chromium.org/1861813003/diff/20001/chrome/browser/ui/webui... File chrome/browser/ui/webui/help/help_handler.cc (right): https://codereview.chromium.org/1861813003/diff/20001/chrome/browser/ui/webui... chrome/browser/ui/webui/help/help_handler.cc:240: {"upToDate", IDS_UPGRADE_UP_TO_DATE}, On 2016/04/05 23:39:06, jdufault wrote: > Put this next to the other upToDate string insertion, only do it if OS_CHROMEOS > is not defined. Done.
lgtm
Description was changed from ========== Display device specific up to date message on chromebook. BUG=585277 COMPONENT=ChromeOS, WebUI->help ========== to ========== Display device specific up to date message on chromebook. BUG=585277 COMPONENT=ChromeOS, WebUI->help ==========
malaykeshav@chromium.org changed reviewers: + xiyuan@chromium.org
On 2016/04/06 19:22:21, jdufault wrote: > lgtm Ping for review
Patchset #3 (id:60001) has been deleted
Patchset #3 (id:80001) has been deleted
lgtm
The CQ bit was checked by malaykeshav@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1861813003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1861813003/40001
Message was sent while issue was closed.
Description was changed from ========== Display device specific up to date message on chromebook. BUG=585277 COMPONENT=ChromeOS, WebUI->help ========== to ========== Display device specific up to date message on chromebook. BUG=585277 COMPONENT=ChromeOS, WebUI->help ==========
Message was sent while issue was closed.
Committed patchset #2 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Display device specific up to date message on chromebook. BUG=585277 COMPONENT=ChromeOS, WebUI->help ========== to ========== Display device specific up to date message on chromebook. BUG=585277 COMPONENT=ChromeOS, WebUI->help Committed: https://crrev.com/592a75487c5bb79fe16f643d2cd3fcdb2982a1d7 Cr-Commit-Position: refs/heads/master@{#386475} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/592a75487c5bb79fe16f643d2cd3fcdb2982a1d7 Cr-Commit-Position: refs/heads/master@{#386475} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
