Change BrowserThreadDelegate to run Init() async.

android_webview/browser/net/aw_url_request_context_getter.h

Index: android_webview/browser/net/aw_url_request_context_getter.h
diff --git a/android_webview/browser/net/aw_url_request_context_getter.h b/android_webview/browser/net/aw_url_request_context_getter.h
index 418e921f2cdc94b6229e603715eeb7b2a2b23d80..93d59aa0e4542eec0e877e3edb95526f13ccbfaf 100644
--- a/android_webview/browser/net/aw_url_request_context_getter.h
+++ b/android_webview/browser/net/aw_url_request_context_getter.h
@@ -35,6 +35,7 @@ class AwURLRequestContextGetter : public net::URLRequestContextGetter,
 
   // content::BrowserThreadDelegate implementation.
   virtual void Init() OVERRIDE;
+  virtual void InitAsync() OVERRIDE;
   virtual void CleanUp() OVERRIDE {}
 
   // net::URLRequestContextGetter implementation.
@@ -58,6 +59,7 @@ class AwURLRequestContextGetter : public net::URLRequestContextGetter,
   void PopulateNetworkSessionParams(net::HttpNetworkSession::Params* params);
 
   AwBrowserContext* browser_context_;  // weak
+  scoped_refptr<net::CookieStore> cookie_store_;

[Kristian Monsen, 2013/07/16 20:04:09]

It would be nice to be able to avoid creating this, but I didn't see an obvious
way to do that.

If that is not possible, maybe a comment saying how this variable is used, and
that it is expected to be null after init?

[joth, 2013/07/16 20:19:52]

agree to that -- comment would be good.

Or alternatively, just don't NULL it out in InitAsync? The cookie store needs to
live as long as the URL context getter, and it's refcounted, so we might as well
hold onto it here for the duration.

This will also make it easier to tidy up the init flow further in future --
rather than the random call out to DidCreateCookieMonster() we'd just add an
explicit call to
GetDefaultBrowserContext()->GetURLContextGetter()->GetCookieStore() when it is
needed.

   scoped_ptr<net::URLRequestContext> url_request_context_;
   scoped_ptr<net::ProxyConfigService> proxy_config_service_;
   scoped_ptr<net::URLRequestJobFactory> job_factory_;