third_party/WebKit/LayoutTests/http/tests/preload/document_write_preload_stubs.html - Issue 1861793002: Add more layout tests for DocumentWriteEvaluator

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/http/tests/preload/document_write_preload_stubs.html

Issue 1861793002: Add more layout tests for DocumentWriteEvaluator (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/LayoutTests/http/tests/preload/document_write_preload.html ('K') | « third_party/WebKit/LayoutTests/http/tests/preload/document_write_preload.html ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <script src="../resources/testharness.js"></script>	2 <script src="../resources/testharness.js"></script>

3 <script src="../resources/testharnessreport.js"></script>	3 <script src="../resources/testharnessreport.js"></script>

4 <script>	4 <script>

5 var t = async_test('Simple scripts that inject external scripts via document.wri te should be preloaded');	5 var t = async_test('Accessors like location should be properly stubbed to aid in preloading scripts injected via document.write');

6 // We reject scripts with "for"	6 // We reject scripts with "for"

7 window.perf = window.performance;	7 window.perf = window.performance;

8 </script>	8 </script>

9 <script>	9 <script>

10 if (window.perf)	10 if (window.perf)

11 var boundedStart = window.perf.now();	11 var boundedStart = window.perf.now();

12 var src = '../resources/dummy.js';	12 var src = window.location.protocol + '//' + window.location.hostname + ':8000' + '/resources/dummy.js';
	Bryan McQuade 2016/04/05 20:34:09 IIUC cross origin resources report timing values o IIUC cross origin resources report timing values of zero. Charlie Harrison 2016/04/05 21:56:30 Does this count as cross origin? I'm seeing valid Show quoted text On 2016/04/05 20:34:09, Bryan McQuade wrote: > IIUC cross origin resources report timing values of zero. Does this count as cross origin? I'm seeing valid startTimes locally.
13 document.write('<scr' + 'ipt src="' + src + '"></scr' + 'ipt>');	13 document.write('<scr' + 'ipt src="' + src + '"></scr' + 'ipt>');

14 </script>	14 </script>

15 <script>	15 <script>

16 window.addEventListener("load", t.step_func(function() {	16 window.addEventListener("load", t.step_func(function() {

17 var resourceTiming = window.performance.getEntriesByType('resource')[2];	17 window.performance.getEntriesByType('resource').forEach(function(r) {

18 assert_less_than(resourceTiming.startTime, boundedStart);	18 if (r.name.indexOf('dummy.js') != -1) {

19 t.done();	19 assert_less_than(r.startTime, boundedStart);
	Bryan McQuade 2016/04/05 20:34:09 given the above, we should probably assert that r. given the above, we should probably assert that r.startTime > 0 as well (and in the other tests as well) Charlie Harrison 2016/04/05 21:56:30 Done. Show quoted text On 2016/04/05 20:34:09, Bryan McQuade wrote: > given the above, we should probably assert that r.startTime > 0 as well (and in > the other tests as well) Done.
	20 t.done();

	21 }

	22 });

20 }));	23 }));

21 </script>	24 </script>

22	25

OLD	NEW