Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1861753002:
Enable IntersectionObserver by default. (Closed)
DescriptionEnable IntersectionObserver by default.
Intent to Ship:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/FcxvG5Jq4w0/wLWtyndoBAAJ
BUG=540528
R=ojan@chromium.org
Committed: https://crrev.com/87fe5caf2ab2113388c6928c0f769525ba366d7e
Cr-Commit-Position: refs/heads/master@{#385347}
Patch Set 1 #Patch Set 2 : fix global-interface-listing #
Messages
Total messages: 26 (12 generated)
Description was changed from ========== Enable IntersectionObserver by default. BUG=540528 R=ojan@chromium.org ========== to ========== Enable IntersectionObserver by default. BUG=540528 R=ojan@chromium.org ==========
szager@chromium.org changed reviewers: + eae@chromium.org
* puts on bureaucracy hat * The CL description needs a link to the Intent to Ship treat https://groups.google.com/a/chromium.org/d/msg/blink-dev/FcxvG5Jq4w0/wLWtyndo... the launch bug needs to be updated (it's currently titled 'Intent to Implement') and the feature on the chromestatus.com needs to be up to date. https://www.chromestatus.com/features/5695342691483648
Description was changed from ========== Enable IntersectionObserver by default. BUG=540528 R=ojan@chromium.org ========== to ========== Enable IntersectionObserver by default. Intent to Ship: https://groups.google.com/a/chromium.org/d/msg/blink-dev/FcxvG5Jq4w0/wLWtyndo... BUG=540528 R=ojan@chromium.org ==========
On 2016/04/05 21:10:55, eae wrote: > * puts on bureaucracy hat * > > The CL description needs a link to the Intent to Ship treat > > https://groups.google.com/a/chromium.org/d/msg/blink-dev/FcxvG5Jq4w0/wLWtyndo... > > the launch bug needs to be updated (it's currently titled 'Intent to Implement') > and the feature on the http://chromestatus.com needs to be up to date. > > https://www.chromestatus.com/features/5695342691483648 Done, done, and done.
Awesome, LGTM
The CQ bit was checked by eae@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1861753002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1861753002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_blink_oilpan_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_blink_oil...)
The CQ bit was checked by szager@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from eae@chromium.org Link to the patchset: https://codereview.chromium.org/1861753002/#ps20001 (title: "fix global-interface-listing")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1861753002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1861753002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
szager@chromium.org changed reviewers: + chrishtr@chromium.org
+chrishtr for API_OWNERS
lgtm
The CQ bit was checked by szager@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1861753002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1861753002/20001
Message was sent while issue was closed.
Description was changed from ========== Enable IntersectionObserver by default. Intent to Ship: https://groups.google.com/a/chromium.org/d/msg/blink-dev/FcxvG5Jq4w0/wLWtyndo... BUG=540528 R=ojan@chromium.org ========== to ========== Enable IntersectionObserver by default. Intent to Ship: https://groups.google.com/a/chromium.org/d/msg/blink-dev/FcxvG5Jq4w0/wLWtyndo... BUG=540528 R=ojan@chromium.org ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Enable IntersectionObserver by default. Intent to Ship: https://groups.google.com/a/chromium.org/d/msg/blink-dev/FcxvG5Jq4w0/wLWtyndo... BUG=540528 R=ojan@chromium.org ========== to ========== Enable IntersectionObserver by default. Intent to Ship: https://groups.google.com/a/chromium.org/d/msg/blink-dev/FcxvG5Jq4w0/wLWtyndo... BUG=540528 R=ojan@chromium.org Committed: https://crrev.com/87fe5caf2ab2113388c6928c0f769525ba366d7e Cr-Commit-Position: refs/heads/master@{#385347} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/87fe5caf2ab2113388c6928c0f769525ba366d7e Cr-Commit-Position: refs/heads/master@{#385347} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
