Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 1861733002: Add touch drag UMA latency metric. (Closed)

Created:
4 years, 8 months ago by tdresser
Modified:
4 years, 7 months ago
CC:
asvitkine+watch_chromium.org, chromium-reviews, darin-cc_chromium.org, dtapuska+chromiumwatch_chromium.org, jam, tdresser+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add touch drag UMA latency metric. Histograms added are: Event.Latency.QueueingTime.TouchMoveDefaultPrevented Event.Latency.QueueingTime.TouchMoveDefaultAllowed Event.Latency.BlockingTime.TouchMoveDefaultPrevented Event.Latency.BlockingTime.TouchMoveDefaultAllowed TEST=RenderWidgetHostLatencyTrackerTest.TouchBlockingAndQueueingTime BUG=600729 Committed: https://crrev.com/351bb0367f7f1019c5d6aabd5682d16a0f1bec80 Cr-Commit-Position: refs/heads/master@{#395883}

Patch Set 1 #

Patch Set 2 : Fix tests. #

Patch Set 3 : Actually fix tests. #

Total comments: 3

Patch Set 4 : Fix everything. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+250 lines, -84 lines) Patch
M content/browser/renderer_host/input/render_widget_host_latency_tracker.h View 1 2 3 4 chunks +14 lines, -1 line 0 comments Download
M content/browser/renderer_host/input/render_widget_host_latency_tracker.cc View 1 2 3 6 chunks +108 lines, -69 lines 0 comments Download
M content/browser/renderer_host/input/render_widget_host_latency_tracker_unittest.cc View 1 2 3 11 chunks +81 lines, -8 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.cc View 1 2 3 4 chunks +9 lines, -6 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 3 2 chunks +38 lines, -0 lines 0 comments Download

Messages

Total messages: 32 (12 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1861733002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1861733002/1
4 years, 8 months ago (2016-04-05 15:29:47 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_rel/builds/90367)
4 years, 8 months ago (2016-04-05 15:46:58 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1861733002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1861733002/20001
4 years, 8 months ago (2016-04-05 15:52:54 UTC) #6
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/207160)
4 years, 8 months ago (2016-04-05 16:10:41 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1861733002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1861733002/40001
4 years, 8 months ago (2016-04-05 16:16:45 UTC) #10
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-05 17:30:24 UTC) #12
tdresser
PTAL
4 years, 8 months ago (2016-04-05 17:32:25 UTC) #14
aelias_OOO_until_Jul13
https://codereview.chromium.org/1861733002/diff/40001/content/browser/renderer_host/input/render_widget_host_latency_tracker.h File content/browser/renderer_host/input/render_widget_host_latency_tracker.h (right): https://codereview.chromium.org/1861733002/diff/40001/content/browser/renderer_host/input/render_widget_host_latency_tracker.h#newcode52 content/browser/renderer_host/input/render_widget_host_latency_tracker.h:52: bool defaultPrevented); I think it might be useful to ...
4 years, 8 months ago (2016-04-05 18:35:19 UTC) #15
Ilya Sherman
metrics LGTM, though I'd encourage you to use 50 buckets rather than 100, unless you're ...
4 years, 8 months ago (2016-04-06 01:34:54 UTC) #16
Ilya Sherman
Hi, what's the status of this CL?
4 years, 7 months ago (2016-05-17 18:22:27 UTC) #17
tdresser
On 2016/05/17 18:22:27, Ilya Sherman wrote: > Hi, what's the status of this CL? Whoops, ...
4 years, 7 months ago (2016-05-17 20:36:22 UTC) #18
tdresser
On 2016/05/17 20:36:22, tdresser wrote: > On 2016/05/17 18:22:27, Ilya Sherman wrote: > > Hi, ...
4 years, 7 months ago (2016-05-18 17:53:54 UTC) #19
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1861733002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1861733002/60001
4 years, 7 months ago (2016-05-19 20:02:44 UTC) #21
tdresser
PTAL. https://codereview.chromium.org/1861733002/diff/40001/content/browser/renderer_host/input/render_widget_host_latency_tracker.cc File content/browser/renderer_host/input/render_widget_host_latency_tracker.cc (right): https://codereview.chromium.org/1861733002/diff/40001/content/browser/renderer_host/input/render_widget_host_latency_tracker.cc#newcode327 content/browser/renderer_host/input/render_widget_host_latency_tracker.cc:327: blocking_delta.InMicroseconds(), 1, 1000000, 100); On 2016/04/06 01:34:54, Ilya ...
4 years, 7 months ago (2016-05-19 20:48:08 UTC) #22
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/216826)
4 years, 7 months ago (2016-05-19 22:48:01 UTC) #24
tdresser
aelias: ping.
4 years, 7 months ago (2016-05-24 20:37:22 UTC) #25
aelias_OOO_until_Jul13
lgtm
4 years, 7 months ago (2016-05-24 22:51:19 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1861733002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1861733002/60001
4 years, 7 months ago (2016-05-25 12:37:42 UTC) #29
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 7 months ago (2016-05-25 13:53:55 UTC) #30
commit-bot: I haz the power
4 years, 7 months ago (2016-05-25 13:55:04 UTC) #32
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/351bb0367f7f1019c5d6aabd5682d16a0f1bec80
Cr-Commit-Position: refs/heads/master@{#395883}

Powered by Google App Engine
This is Rietveld 408576698