Background service worker push message processing

chrome/browser/push_messaging/background_budget_service_unittest.cc

Index: chrome/browser/push_messaging/background_budget_service_unittest.cc
diff --git a/chrome/browser/push_messaging/background_budget_service_unittest.cc b/chrome/browser/push_messaging/background_budget_service_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..3c087eb5dbe008bdbab919bab81e3a83dbc56e2b
--- /dev/null
+++ b/chrome/browser/push_messaging/background_budget_service_unittest.cc
@@ -0,0 +1,75 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include <stdint.h>
+#include <string>
+
+#include "base/run_loop.h"
+#include "chrome/browser/push_messaging/background_budget_service.h"
+#include "chrome/test/base/testing_profile.h"
+#include "content/public/test/test_browser_thread_bundle.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace {
+
+const char kTestOrigin[] = "https://example.com";
+const char kTestData[] = "1111101111";
+
+}  // namespace
+
+class BackgroundBudgetServiceTest : public ::testing::Test {
+ public:
+  BackgroundBudgetServiceTest() {}
+  ~BackgroundBudgetServiceTest() override {}
+
+  void DidGetBudget(const std::string& data) {
+    if (!data.empty())
+      success_ = true;
+    data_ = data;
+  }
+
+  void DidStoreBudget(bool success) { success_ = success; }
+
+  TestingProfile* profile() { return &profile_; }
+
+  bool success_ = false;
+  std::string data_;
+
+ private:
+  content::TestBrowserThreadBundle thread_bundle_;
+  TestingProfile profile_;
+};
+
+TEST_F(BackgroundBudgetServiceTest, GetBudgetFailure) {
+  const GURL origin(kTestOrigin);
+
+  chrome::BackgroundBudgetService::GetBudget(
+      profile(), GURL(kTestOrigin),
+      base::Bind(&BackgroundBudgetServiceTest::DidGetBudget,
+                 base::Unretained(this)));
+
+  base::RunLoop().RunUntilIdle();

[Peter Beverloo, 2016/04/11 10:55:59]

Please remove this. (Also on line 64 and 71, and the include on line 8.)

[harkness, 2016/04/11 13:21:35]

Done.

+
+  EXPECT_EQ(success_, false);
+  EXPECT_EQ(data_, std::string());

[Peter Beverloo, 2016/04/11 10:55:59]

nit: you'll get a slightly nicer message if you write it as:

EXPECT_FALSE(success_);
EXPECT_TRUE(data_.empty());

(dito on line 73)

[harkness, 2016/04/11 13:21:34]

Done.

+}
+
+TEST_F(BackgroundBudgetServiceTest, GetBudgetSuccess) {
+  const GURL origin(kTestOrigin);
+
+  chrome::BackgroundBudgetService::StoreBudget(profile(), GURL(kTestOrigin),
+                                               kTestData);
+
+  base::RunLoop().RunUntilIdle();
+
+  chrome::BackgroundBudgetService::GetBudget(
+      profile(), GURL(kTestOrigin),
+      base::Bind(&BackgroundBudgetServiceTest::DidGetBudget,
+                 base::Unretained(this)));
+
+  base::RunLoop().RunUntilIdle();
+
+  EXPECT_EQ(success_, true);
+  EXPECT_EQ(data_, kTestData);
+}