Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Unified Diff: src/log.cc

Issue 186163002: Add support for allowing an embedder to get the V8 profile timer event logs. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Renamings Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« src/log.h ('K') | « src/log.h ('k') | test/cctest/test-api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/log.cc
diff --git a/src/log.cc b/src/log.cc
index 1c332d1736318fdccd8f8a313545019df7e6469a..d4431dcd233944a848a15ad70d0f861cd17699df 100644
--- a/src/log.cc
+++ b/src/log.cc
@@ -1125,7 +1125,13 @@ void Logger::LeaveExternal(Isolate* isolate) {
void Logger::TimerEventScope::LogTimerEvent(StartEnd se) {
- LOG(isolate_, TimerEvent(se, name_));
+ if (FLAG_log_internal_timer_events)
Yang 2014/03/05 08:18:31 We always use brackets if an if-clause contains a
fmeawad 2014/03/06 00:24:46 Fixed in Patch 5, removed in Patch 6.
+ LOG(isolate_, TimerEvent(se, name_));
+ if (se == START) {
+ LOG_EVENT_BEGIN(isolate_, name_);
+ } else {
+ LOG_EVENT_END(isolate_, name_);
+ }
}
« src/log.h ('K') | « src/log.h ('k') | test/cctest/test-api.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698